public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] sh: i2c: Add support I2C controller of SH7734
Date: Wed, 15 Feb 2012 08:54:33 +0100	[thread overview]
Message-ID: <4F3B64B9.9050805@denx.de> (raw)
In-Reply-To: <1329291999-27785-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hello Nobuhiro,

Nobuhiro Iwamatsu wrote:
> Renesas SH7734 has two I2C interfaceis.
> This supports these I2C.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> V2: - Changed bit control to use the clr|set|clrsetbits_* functions.
>     - Fix wrong comment style.
> 	- Add new line before for loop in i2c_read.
> 
>  drivers/i2c/Makefile        |    1 +
>  drivers/i2c/sh_sh7734_i2c.c |  445 +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 446 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/i2c/sh_sh7734_i2c.c

[hs at pollux u-boot]$ ./tools/checkpatch.pl index.html
ERROR: trailing whitespace
#238: FILE: drivers/i2c/sh_sh7734_i2c.c:193:
+^Isetbits_8(&base->iccr2, SH_I2C_ICCR2_IICRST);^I$

total: 1 errors, 0 warnings, 452 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE

index.html has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[hs at pollux u-boot]$

Beside of that, I Ack this patch only, so you can pick it up in your
u-boot-sh.git tree, because it is dependend on the following patch
from you:

sh: Add bit control functions
http://patchwork.ozlabs.org/patch/141259/

If this is Ok for you, please add my:

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2012-02-15  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15  7:46 [U-Boot] [PATCH v2] sh: i2c: Add support I2C controller of SH7734 Nobuhiro Iwamatsu
2012-02-15  7:54 ` Heiko Schocher [this message]
2012-02-22  1:15   ` Nobuhiro Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3B64B9.9050805@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox