public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Amit Virdi <amit.virdi@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SPEAr: Add ARM relocation support
Date: Fri, 17 Feb 2012 09:36:27 +0530	[thread overview]
Message-ID: <4F3DD243.60404@st.com> (raw)
In-Reply-To: <201202162043.44460.marek.vasut@gmail.com>


On 2/17/2012 1:13 AM, Marek Vasut wrote:
>> Signed-off-by: Amit Virdi<amit.virdi@st.com>
>
> Uh, are you sure the Subject correlates with the patch ?
>
> M
>

Yeah. The fix is a part of the Relocation feature. For relocation, it is 
essential that dram_init stores RAM size and do nothing more i.e. no 
access to bss etc.

~Amit Virdi

>> ---
>>   board/spear/common/spr_misc.c |   20 +-------------------
>>   1 files changed, 1 insertions(+), 19 deletions(-)
>>
>> diff --git a/board/spear/common/spr_misc.c b/board/spear/common/spr_misc.c
>> index 0812c20..3ab278f 100644
>> --- a/board/spear/common/spr_misc.c
>> +++ b/board/spear/common/spr_misc.c
>> @@ -40,27 +40,9 @@ static struct chip_data chip_data;
>>
>>   int dram_init(void)
>>   {
>> -	struct xloader_table *xloader_tb =
>> -	    (struct xloader_table *)XLOADER_TABLE_ADDRESS;
>> -	struct xloader_table_1_1 *table_1_1;
>> -	struct xloader_table_1_2 *table_1_2;
>> -	struct chip_data *chip =&chip_data;
>> -
>> +	/* Store complete RAM size and return */
>>   	gd->ram_size = get_ram_size(PHYS_SDRAM_1, PHYS_SDRAM_1_MAXSIZE);
>>
>> -	if (XLOADER_TABLE_VERSION_1_1 == xloader_tb->table_version) {
>> -		table_1_1 =&xloader_tb->table.table_1_1;
>> -		chip->dramfreq = table_1_1->ddrfreq;
>> -		chip->dramtype = table_1_1->ddrtype;
>> -
>> -	} else if (XLOADER_TABLE_VERSION_1_2 == xloader_tb->table_version) {
>> -		table_1_2 =&xloader_tb->table.table_1_2;
>> -		chip->dramfreq = table_1_2->ddrfreq;
>> -		chip->dramtype = table_1_2->ddrtype;
>> -	} else {
>> -		chip->dramfreq = -1;
>> -	}
>> -
>>   	return 0;
>>   }
> .
>

  reply	other threads:[~2012-02-17  4:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 11:43 [U-Boot] [PATCH] SPEAr: Add ARM relocation support Amit Virdi
2012-02-16 19:43 ` Marek Vasut
2012-02-17  4:06   ` Amit Virdi [this message]
2012-02-17  8:58     ` Marek Vasut
2012-02-18  7:33       ` Amit Virdi
2012-02-18  7:45         ` Marek Vasut
2012-02-17  9:13     ` Albert ARIBAUD
2012-02-18  7:35       ` Amit Virdi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3DD243.60404@st.com \
    --to=amit.virdi@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox