From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Sat, 18 Feb 2012 16:42:08 +0530 Subject: [U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions In-Reply-To: <201202171213.18516.vapier@gentoo.org> References: <1328528248-20872-1-git-send-email-aneesh@ti.com> <1329314253-4596-3-git-send-email-aneesh@ti.com> <201202171213.18516.vapier@gentoo.org> Message-ID: <4F3F8788.90101@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 17 February 2012 10:43 PM, Mike Frysinger wrote: > On Wednesday 15 February 2012 08:57:31 Aneesh V wrote: >> This is done using the following directive preceding >> each function definition: >> >> .type, %function >> >> This marks the symbol as a function in the object >> header which in turn helps the linker in some cases. >> >> In particular this was found needed for resolving ARM/Thumb >> calls correctly in a build with Thumb interworking enabled. > > ideally arm would use the new linkage.h header and then these would change to > doing what Linux does: > ENTRY(foo) > > ENDPROC(foo) Thanks for the info. So, what do you suggest? Fix only the problematic function and leave the rest to be converted to the above form later? br, Aneesh