From: Matthias Fuchs <matthias.fuchs@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] i.mx28: Elimintated magic numbers for scratch register addresses
Date: Mon, 20 Feb 2012 09:56:41 +0100 [thread overview]
Message-ID: <4F420AC9.1030703@esd.eu> (raw)
In-Reply-To: <201202200932.24625.marek.vasut@gmail.com>
On 20.02.2012 09:32, Marek Vasut wrote:
>> Marek, Stefano,
>>
>> what kept you from accepting these patches? There was no objection on
>> these.
>
> The regs-digctl.h file being incomplete, it didn't contain all the bit
> definitions even though I shared the tool to convert file provided by FSL to
> uboot format.
Why must this file be absolute complete? It can be extended on need.
This just slows down development and as you might have noticed, that it
chases away some developers.
So accepting this patch is a first step. And hopefully the rest is added
sometimes later. If not, well, then nobody needs it and there's no need
to blow the headers.
Matthias
>
> M
>
>>
>> Matthias
>>
>> On 07.02.2012 15:08, robert at delien.nl wrote:
>>> From: Robert Delien <robert@delien.nl>
>>>
>>> This patch eliminates the use of magic numbers for the scratch register
>>> addresses. The registers in the DIGCTL sections are now defined and
>>> used to access the scratch registers.
>>>
>>> Robert Delien (2):
>>> Added register definitions for DIGCTL registers
>>> Replaced magic numbers for scratch register addresses with register
>>>
>>> definitions
>>>
>>> arch/arm/cpu/arm926ejs/mx28/mx28.c | 8 +-
>>> arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c | 8 +-
>>> arch/arm/include/asm/arch-mx28/imx-regs.h | 1 +
>>> arch/arm/include/asm/arch-mx28/regs-digctl.h | 155
>>> ++++++++++++++++++++++++++ 4 files changed, 164 insertions(+), 8
>>> deletions(-)
>>> create mode 100644 arch/arm/include/asm/arch-mx28/regs-digctl.h
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>
--
------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design
esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
Besuchen Sie uns auf der embedded world 2012
in Halle 4, Stand 129
vom 28. Februar - 01. M?rz 2012 in N?rnberg!
------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------
next prev parent reply other threads:[~2012-02-20 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 14:08 [U-Boot] [PATCH 0/2] i.mx28: Elimintated magic numbers for scratch register addresses robert at delien.nl
2012-02-07 14:08 ` [U-Boot] [PATCH 1/2] i.mx28: Added register definitions for DIGCTL registers robert at delien.nl
2012-02-07 16:51 ` Marek Vasut
2012-02-07 17:01 ` Robert Deliën
2012-02-20 9:24 ` Stefano Babic
2012-02-07 14:08 ` [U-Boot] [PATCH 2/2] i.mx28: Replaced magic numbers for scratch register addresses with register definitions robert at delien.nl
2012-02-07 16:51 ` Marek Vasut
2012-02-20 9:25 ` Stefano Babic
2012-02-20 7:53 ` [U-Boot] [PATCH 0/2] i.mx28: Elimintated magic numbers for scratch register addresses Matthias Fuchs
2012-02-20 8:32 ` Marek Vasut
2012-02-20 8:56 ` Matthias Fuchs [this message]
2012-02-20 9:18 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F420AC9.1030703@esd.eu \
--to=matthias.fuchs@esd.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox