From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Mon, 20 Feb 2012 09:59:46 +0100
Subject: [U-Boot] [PATCH] UBIFS: Improve error message when reading
 superblock failed
In-Reply-To: <1329727489-31423-1-git-send-email-walle@corscience.de>
References: <20120217143110.GA32414@agamemnon.er.corscience.de>
	<1329727489-31423-1-git-send-email-walle@corscience.de>
Message-ID: <4F420B82.2070908@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Bernard,

Le 20/02/2012 09:44, Bernhard Walle a ?crit :
> In addition to the error message also display the error code. I had the
> problem that my malloc memory was not enough (ENOMEM), and if u-boot
> had displayed the error code immediately that would have saved me some
> debugging.
>
> Signed-off-by: Bernhard Walle<walle@corscience.de>
> ---
> v2: Print the non-negated error value.
>
>   fs/ubifs/super.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 26b48f0..e6c02f5 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1191,7 +1191,7 @@ int ubifs_mount(char *vol_name)
>   	mnt = NULL;
>   	ret = ubifs_get_sb(&ubifs_fs_type, flags, name, data, mnt);
>   	if (ret) {
> -		printf("Error reading superblock on volume '%s'!\n", name);
> +		printf("Error reading superblock on volume '%s': %d!\n", name, ret);
>   		return -1;
>   	}
>

Dry numbers as error messages are better than no error messages but only 
marginally IMO. Isn't there a way to emit a readable message re malloc 
instead of emitting an int value?

Amicalement,
-- 
Albert.