From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 20 Feb 2012 10:18:31 +0100 Subject: [U-Boot] [PATCH 0/2] i.mx28: Elimintated magic numbers for scratch register addresses In-Reply-To: <201202200932.24625.marek.vasut@gmail.com> References: <1328623736-24872-1-git-send-email-robert@delien.nl> <4F41FC17.5090207@esd.eu> <201202200932.24625.marek.vasut@gmail.com> Message-ID: <4F420FE7.8010400@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 20/02/2012 09:32, Marek Vasut wrote: >> Marek, Stefano, >> >> what kept you from accepting these patches? There was no objection on >> these. > > The regs-digctl.h file being incomplete, it didn't contain all the bit > definitions even though I shared the tool to convert file provided by FSL to > uboot format. My point: most of files in u-boot can be considered incomplete, because they do not define everything, but only what is *currently* used in U-boot. I have not merged this patch because in the thread I read Robert wanted to send an updated patch, and this made this version automatically obsolete. I agree we can merge this patch - and we can always push later a patch adding the bit definitions, when it will be necessary. Best Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================