[U-Boot] [PATCH 0/2] i.mx28: Elimintated magic numbers for scratch register addresses

Matthias Fuchs
2012-02-20T08:56:41Z

On 20.02.2012 09:32, Marek Vasut wrote:
>> Marek, Stefano,
>>
>> what kept you from accepting these patches? There was no objection on
>> these.
>
> The regs-digctl.h file being incomplete, it didn't contain all the bit
> definitions even though I shared the tool to convert file provided by FSL to
> uboot format.
Why must this file be absolute complete? It can be extended on need.
This just slows down development and as you might have noticed, that it
chases away some developers.

So accepting this patch is a first step. And hopefully the rest is added
sometimes later. If not, well, then nobody needs it and there's no need
to blow the headers.

Matthias

>
> M
>
>>
>> Matthias
>>
>> On 07.02.2012 15:08, robert at delien.nl wrote:
>>> From: Robert Delien <robert@delien.nl>
>>>
>>> This patch eliminates the use of magic numbers for the scratch register
>>> addresses. The registers in the DIGCTL sections are now defined and
>>> used to access the scratch registers.
>>>
>>> Robert Delien (2):
>>> Added register definitions for DIGCTL registers
>>> Replaced magic numbers for scratch register addresses with register
>>>
>>> definitions
>>>
>>> arch/arm/cpu/arm926ejs/mx28/mx28.c | 8 +-
>>> arch/arm/cpu/arm926ejs/mx28/spl_mem_init.c | 8 +-
>>> arch/arm/include/asm/arch-mx28/imx-regs.h | 1 +
>>> arch/arm/include/asm/arch-mx28/regs-digctl.h | 155
>>> ++++++++++++++++++++++++++ 4 files changed, 164 insertions(+), 8
>>> deletions(-)
>>> create mode 100644 arch/arm/include/asm/arch-mx28/regs-digctl.h
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot at lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>

--
------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany

Besuchen Sie uns auf der embedded world 2012
in Halle 4, Stand 129
vom 28. Februar - 01. M?rz 2012 in N?rnberg!
------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------