[U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

Simon Glass
2012-02-20T21:53:40Z

Hi Tom, Aneesh,

On Mon, Feb 20, 2012 at 12:07 PM, Tom Rini <trini@ti.com> wrote:
> On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote:
>> On Saturday 18 February 2012 17:03:59 Simon Glass wrote:
>> > On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote:
>> > > -.globl reset_cpu
>> > > +.type ?reset_cpu, %function
>> > > +.global ? ? ? ?reset_cpu
>> >
>> > Should we introduce a macro to deal with this rather than writing it
>> > out each time? EXPORT()?
>>
>> we have it already with the linux/linkage.h header :)
>
> Well, unless my tree is out of date (or stuff is in-flight) we don't
> have the full compliment here. ?We have <linux/linkage.h> for all and
> <asm/linkage.h> for bfin. ?That said, yes, we should grab at least the
> ARM version and make use of ENTRY/END_FUNC ala the kernel. ?I'm behind
> on my "convert __attribute__((...)) to __attr" series already or I'd say
> more :)

In case one of you is going to look at this, can we try to use
asm-generic as much as possible?

>
> --
> Tom
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Simon