[U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

Mike Frysinger
2012-02-21T04:18:11Z

On Monday 20 February 2012 15:07:46 Tom Rini wrote:
> On Sun, Feb 19, 2012 at 02:15:30AM -0500, Mike Frysinger wrote:
> > On Saturday 18 February 2012 17:03:59 Simon Glass wrote:
> > > On Wed, Feb 15, 2012 at 5:57 AM, Aneesh V wrote:
> > > > -.globl reset_cpu
> > > > +.type reset_cpu, %function
> > > > +.global reset_cpu
> > >
> > > Should we introduce a macro to deal with this rather than writing it
> > > out each time? EXPORT()?
> >
> > we have it already with the linux/linkage.h header :)
>
> Well, unless my tree is out of date (or stuff is in-flight) we don't
> have the full compliment here. We have <linux/linkage.h> for all and
> <asm/linkage.h> for bfin. That said, yes, we should grab at least the
> ARM version and make use of ENTRY/END_FUNC ala the kernel. I'm behind
> on my "convert __attribute__((...)) to __attr" series already or I'd say
> more :)

yes, each arch is responsible for bringing in their asm/linkage.h needs into
u-boot. makes more sense to me to do that in arm than trying to hand modify a
bunch of random funcs that people happen to notice issues with.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120220/0367786a/attachment.pgp>