[U-Boot] [PATCH 2/4] arm: add %function attribute to assembly functions

Albert ARIBAUD
2012-02-18T11:34:51Z

Hi Aneesh,

Le 18/02/2012 12:12, Aneesh V a ?crit :
> On Friday 17 February 2012 10:43 PM, Mike Frysinger wrote:
>> On Wednesday 15 February 2012 08:57:31 Aneesh V wrote:
>>> This is done using the following directive preceding
>>> each function definition:
>>>
>>> .type<func-name>, %function
>>>
>>> This marks the symbol as a function in the object
>>> header which in turn helps the linker in some cases.
>>>
>>> In particular this was found needed for resolving ARM/Thumb
>>> calls correctly in a build with Thumb interworking enabled.
>>
>> ideally arm would use the new linkage.h header and then these would
>> change to
>> doing what Linux does:
>> ENTRY(foo)
>> <asm>
>> ENDPROC(foo)
>
> Thanks for the info. So, what do you suggest? Fix only the problematic
> function and leave the rest to be converted to the above form later?

Please at the very least do not leave any file half-baked, with some
symbols fixed and other not. Any file you start fixing should be
entirely fixed.

Regarding fixing other ASM files unrelated to your patch set, then no,
you don't need to fix them. Others will have to do any outstanding fixes
them when they add Thumb support for their own target.

Amicalement,
--
Albert.