From mboxrd@z Thu Jan  1 00:00:00 1970
From: stefano babic <sbabic@denx.de>
Date: Tue, 21 Feb 2012 22:49:27 +0100
Subject: [U-Boot] [PATCH] imximage: header v2: Remove overwriting of
	flash_offset
In-Reply-To: <4F43EE05.4090908@googlemail.com>
References: <1329814920-12295-1-git-send-email-dirk.behme@de.bosch.com>
	<4F43DAEF.8050907@denx.de> <4F43EE05.4090908@googlemail.com>
Message-ID: <4F441167.9050003@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am 21/02/2012 20:18, schrieb Dirk Behme:

>> I think we have then a problem when there is not a BOOT_FROM statement
>> in the configuration file, that let  imxhdr->flash_offset unset.
>>
>> We need to set it with the default value
> 
> Hmm, my understanding is that there can't be any default value? 

This is desirable, but it does not correspond to the code.

> What do
> you think would be a default value? The one for SD boot? The one for
> NAND? Or? Who will decide what the default should be?

Whatever we choose, it is wrong. We can select SD, and one board has not
a SD interface. The same with NAND, ...

The best one is we have not a default value.

> 
>> at the beginning of the
>> processing or to raise an error if we want to make this statement
>> mandatory in the configuration file.
> 
> If there can't be a default value, I think to raise an error if no
> BOOT_FROM statement is there is the only option.

Agree - BOOT_FROM must be mandatory.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================