[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Stephan Linz]

Oops, I've given a wrong sender. Please drop the patch. I'll resend ...

br,
Stephan

Am Samstag, den 18.02.2012, 11:41 +0100 schrieb y: 
> From: Stephan Linz <linz@li-pro.net>
> 
> after http://patchwork.ozlabs.org/patch/136415/ was applied.
> The Microblaze generic build fails with below error
> 
> common/libcommon.o: In function `cread_line':
> /devel/u-boot/common/main.c:717: undefined reference to `get_ticks'
> /devel/u-boot/common/main.c:717: undefined reference to `get_tbclk'
> /devel/u-boot/common/main.c:720: undefined reference to `get_ticks'
> 
> Signed-off-by: Stephan Linz <linz@li-pro.net>
> ---
>  arch/microblaze/cpu/timer.c |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/microblaze/cpu/timer.c b/arch/microblaze/cpu/timer.c
> index a167755..1952804 100644
> --- a/arch/microblaze/cpu/timer.c
> +++ b/arch/microblaze/cpu/timer.c
> @@ -62,3 +62,21 @@ int timer_init (void)
>  }
>  #endif
>  #endif
> +
> +/*
> + * This function is derived from PowerPC code (read timebase as long long).
> + * On Microblaze it just returns the timer value.
> + */
> +unsigned long long get_ticks(void)
> +{
> +	return get_timer(0);
> +}
> +
> +/*
> + * This function is derived from PowerPC code (timebase clock frequency).
> + * On Microblaze it returns the number of timer ticks per second.
> + */
> +ulong get_tbclk(void)
> +{
> +	return CONFIG_SYS_HZ;
> +}

-- 
Viele Gr??e,
Stephan Linz
______________________________________________________________________________
MB-Ref: http://www.li-pro.de/xilinx_mb:mbref:start
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
Sourceforge: http://sourceforge.net/users/slz
Gitorious: https://gitorious.org/~slz

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Stephan Linz]

after http://patchwork.ozlabs.org/patch/136415/ was applied.
The Microblaze generic build fails with below error

common/libcommon.o: In function `cread_line':
/devel/u-boot/common/main.c:717: undefined reference to `get_ticks'
/devel/u-boot/common/main.c:717: undefined reference to `get_tbclk'
/devel/u-boot/common/main.c:720: undefined reference to `get_ticks'

Signed-off-by: Stephan Linz <linz@li-pro.net>
---
 arch/microblaze/cpu/timer.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/arch/microblaze/cpu/timer.c b/arch/microblaze/cpu/timer.c
index a167755..1952804 100644
--- a/arch/microblaze/cpu/timer.c
+++ b/arch/microblaze/cpu/timer.c
@@ -62,3 +62,21 @@ int timer_init (void)
 }
 #endif
 #endif
+
+/*
+ * This function is derived from PowerPC code (read timebase as long long).
+ * On Microblaze it just returns the timer value.
+ */
+unsigned long long get_ticks(void)
+{
+	return get_timer(0);
+}
+
+/*
+ * This function is derived from PowerPC code (timebase clock frequency).
+ * On Microblaze it returns the number of timer ticks per second.
+ */
+ulong get_tbclk(void)
+{
+	return CONFIG_SYS_HZ;
+}
-- 
1.7.0.4

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Michal Simek]

Stephan Linz wrote:
> after http://patchwork.ozlabs.org/patch/136415/ was applied.
> The Microblaze generic build fails with below error

Please sure patch subject + sha1 sum instead of link to system
which doesn't need to work in future. Git reference will work.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Stephan Linz]

Am Mittwoch, den 22.02.2012, 10:52 +0100 schrieb Michal Simek: 
> Stephan Linz wrote:
> > after http://patchwork.ozlabs.org/patch/136415/ was applied.
> > The Microblaze generic build fails with below error
> 
> Please sure patch subject + sha1 sum instead of link to system
> which doesn't need to work in future. Git reference will work.

OK, I'll resend the patch. Can I already add your ACK ?


-- 
Best regards,
Stephan Linz
______________________________________________________________________________
MB-Ref: http://www.li-pro.de/xilinx_mb:mbref:start
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
Sourceforge: http://sourceforge.net/users/slz
Gitorious: https://gitorious.org/~slz

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Michal Šimek]

Stephan Linz <linz@li-pro.net> napsal(a):

>Am Mittwoch, den 22.02.2012, 10:52 +0100 schrieb Michal Simek: 
>> Stephan Linz wrote:
>> > after http://patchwork.ozlabs.org/patch/136415/ was applied.
>> > The Microblaze generic build fails with below error
>> 
>> Please sure patch subject + sha1 sum instead of link to system
>> which doesn't need to work in future. Git reference will work.
>
>OK, I'll resend the patch. Can I already add your ACK ?

Yes, you can.

Michal

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Stephan Linz]

after commit 9c34831 was applied. The Microblaze generic build
fails with error below:

common/libcommon.o: In function `cread_line':
/devel/u-boot/common/main.c:717: undefined reference to `get_ticks'
/devel/u-boot/common/main.c:717: undefined reference to `get_tbclk'
/devel/u-boot/common/main.c:720: undefined reference to `get_ticks'

Signed-off-by: Stephan Linz <linz@li-pro.net>
Acked-by: Michal Simek <monstr@monstr.eu>
---
 arch/microblaze/cpu/timer.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/arch/microblaze/cpu/timer.c b/arch/microblaze/cpu/timer.c
index a167755..1952804 100644
--- a/arch/microblaze/cpu/timer.c
+++ b/arch/microblaze/cpu/timer.c
@@ -62,3 +62,21 @@ int timer_init (void)
 }
 #endif
 #endif
+
+/*
+ * This function is derived from PowerPC code (read timebase as long long).
+ * On Microblaze it just returns the timer value.
+ */
+unsigned long long get_ticks(void)
+{
+	return get_timer(0);
+}
+
+/*
+ * This function is derived from PowerPC code (timebase clock frequency).
+ * On Microblaze it returns the number of timer ticks per second.
+ */
+ulong get_tbclk(void)
+{
+	return CONFIG_SYS_HZ;
+}
-- 
1.7.0.4

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Stephan Linz]

after commit "common: add possibility for readline_into_buffer
timeout" (sha1:9c34831) was applied. The Microblaze generic build
fails with error below:

common/libcommon.o: In function `cread_line':
/devel/u-boot/common/main.c:717: undefined reference to `get_ticks'
/devel/u-boot/common/main.c:717: undefined reference to `get_tbclk'
/devel/u-boot/common/main.c:720: undefined reference to `get_ticks'

Signed-off-by: Stephan Linz <linz@li-pro.net>
Acked-by: Michal Simek <monstr@monstr.eu>
---
 arch/microblaze/cpu/timer.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/arch/microblaze/cpu/timer.c b/arch/microblaze/cpu/timer.c
index a167755..1952804 100644
--- a/arch/microblaze/cpu/timer.c
+++ b/arch/microblaze/cpu/timer.c
@@ -62,3 +62,21 @@ int timer_init (void)
 }
 #endif
 #endif
+
+/*
+ * This function is derived from PowerPC code (read timebase as long long).
+ * On Microblaze it just returns the timer value.
+ */
+unsigned long long get_ticks(void)
+{
+	return get_timer(0);
+}
+
+/*
+ * This function is derived from PowerPC code (timebase clock frequency).
+ * On Microblaze it returns the number of timer ticks per second.
+ */
+ulong get_tbclk(void)
+{
+	return CONFIG_SYS_HZ;
+}
-- 
1.7.0.4

[U-Boot] [PATCH] microblaze: fix build failure due to undefined reference to `get_ticks'

[Michal Simek]

Stephan Linz wrote:
> after commit "common: add possibility for readline_into_buffer
> timeout" (sha1:9c34831) was applied. The Microblaze generic build
> fails with error below:
> 
> common/libcommon.o: In function `cread_line':
> /devel/u-boot/common/main.c:717: undefined reference to `get_ticks'
> /devel/u-boot/common/main.c:717: undefined reference to `get_tbclk'
> /devel/u-boot/common/main.c:720: undefined reference to `get_ticks'
> 
> Signed-off-by: Stephan Linz <linz@li-pro.net>
> Acked-by: Michal Simek <monstr@monstr.eu>
> ---
>  arch/microblaze/cpu/timer.c |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/microblaze/cpu/timer.c b/arch/microblaze/cpu/timer.c
> index a167755..1952804 100644
> --- a/arch/microblaze/cpu/timer.c
> +++ b/arch/microblaze/cpu/timer.c
> @@ -62,3 +62,21 @@ int timer_init (void)
>  }
>  #endif
>  #endif
> +
> +/*
> + * This function is derived from PowerPC code (read timebase as long long).
> + * On Microblaze it just returns the timer value.
> + */
> +unsigned long long get_ticks(void)
> +{
> +	return get_timer(0);
> +}
> +
> +/*
> + * This function is derived from PowerPC code (timebase clock frequency).
> + * On Microblaze it returns the number of timer ticks per second.
> + */
> +ulong get_tbclk(void)
> +{
> +	return CONFIG_SYS_HZ;
> +}

Applied.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian