From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Date: Thu, 23 Feb 2012 12:49:22 +0100 Subject: [U-Boot] [PATCH 2/8] microblaze: Enable several ethernet driver compilation In-Reply-To: <00eaabafa2b64a5d5857067588261f35e5581274.1327848193.git.linz@li-pro.net> References: <1327852301.3638.177.camel@keto> <00eaabafa2b64a5d5857067588261f35e5581274.1327848193.git.linz@li-pro.net> Message-ID: <4F4627C2.1070204@monstr.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stephan Linz wrote: > U-Boot's multipple network supports enables to use > several ethernet drivers but microblaze-generic > platform config file select only one driver. > > Reported-by: Michal Simek > Signed-off-by: Stephan Linz > --- > include/configs/microblaze-generic.h | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/include/configs/microblaze-generic.h b/include/configs/microblaze-generic.h > index 03a6f5a..09ac870 100644 > --- a/include/configs/microblaze-generic.h > +++ b/include/configs/microblaze-generic.h > @@ -65,11 +65,15 @@ > > /* ethernet */ > #undef CONFIG_SYS_ENET > -#ifdef XILINX_EMACLITE_BASEADDR > -# define CONFIG_XILINX_EMACLITE 1 > +#if defined(XILINX_EMACLITE_BASEADDR) > +# define CONFIG_XILINX_EMACLITE 1 > # define CONFIG_SYS_ENET > -#elif XILINX_LLTEMAC_BASEADDR > -# define CONFIG_XILINX_LL_TEMAC 1 > +#endif > +#if defined(XILINX_LLTEMAC_BASEADDR) || defined(XILINX_LLTEMAC_BASEADDR1) || \ > + defined(XILINX_LLTEMAC_BASEADDR2) || defined(XILINX_LLTEMAC_BASEADDR3) || \ > + defined(XILINX_LLTEMAC_BASEADDR4) || defined(XILINX_LLTEMAC_BASEADDR5) || \ > + defined(XILINX_LLTEMAC_BASEADDR6) || defined(XILINX_LLTEMAC_BASEADDR7) > +# define CONFIG_XILINX_LL_TEMAC 1 > # define CONFIG_SYS_ENET > #endif > #if defined(XILINX_AXIEMAC_BASEADDR) I don't agree with this. The whole reason is to enable ll_temac driver and I believe that all system with ll_temac will starts with XILINX_LLTEMAC_BASEADDR and then others. Which means if XILINX_LLTEMAC_BASEADDR is there just enable the driver. I just can't see the reason to start with BASEADDR1 or 2 or .... or 7. Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian