From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aneesh V Date: Thu, 23 Feb 2012 20:26:24 +0530 Subject: [U-Boot] [PATCH v3 5/6] omap4+: Avoid using __attribute__ ((__packed__)) In-Reply-To: References: <1328528248-20872-1-git-send-email-aneesh@ti.com> <1330005966-1444-5-git-send-email-aneesh@ti.com> Message-ID: <4F465398.60503@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 23 February 2012 07:51 PM, Tom Rini wrote: > On Thu, Feb 23, 2012 at 7:06 AM, Aneesh V wrote: >> Avoid using __attribute__ ((__packed__)) unless it's >> absolutely necessary. "packed" will remove alignment >> requirements for the respective objects and may cause >> alignment issues unless alignment is also enforced >> using a pragma. >> >> Here, these packed attributes were causing alignment >> faults in Thumb build. >> >> Signed-off-by: Aneesh V > > Why did we pack these to start with? Otherwise seems fine (and I see > the rest of the TI parts don't have this particular packing). > I think that was to save some space - to make sure that the compiler didn't pad the structure to have the u16 fields at word boundary. But even without "packed" the complier is not padding it. I checked that today, the size of the mux arrays remain the same even after removing the "packed". So, I guess the "packed" didn't have any impact.