From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aneesh V <aneesh@ti.com>
Date: Thu, 23 Feb 2012 23:39:43 +0530
Subject: [U-Boot] [PATCH v2 3/5] ARM: enable Thumb build
In-Reply-To: <20120223175118.GA29246@bill-the-cat>
References: <1328528248-20872-1-git-send-email-aneesh@ti.com>
	<1330004385-22502-3-git-send-email-aneesh@ti.com>
	<201202230957.52239.vapier@gentoo.org> <4F467744.40307@ti.com>
	<20120223173412.GA27236@bill-the-cat> <4F467C47.6050508@ti.com>
	<20120223175118.GA29246@bill-the-cat>
Message-ID: <4F4680E7.8050603@ti.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thursday 23 February 2012 11:21 PM, Tom Rini wrote:
> On Thu, Feb 23, 2012 at 11:19:59PM +0530, Aneesh V wrote:
>> On Thursday 23 February 2012 11:04 PM, Tom Rini wrote:
>>> On Thu, Feb 23, 2012 at 10:58:36PM +0530, Aneesh V wrote:
>>>> On Thursday 23 February 2012 08:27 PM, Mike Frysinger wrote:
>>>>> On Thursday 23 February 2012 08:39:43 Aneesh V wrote:
>>>>>> --- a/arch/arm/config.mk
>>>>>> +++ b/arch/arm/config.mk
>>>>>>
>>>>>> -# Explicitly specifiy 32-bit ARM ISA since toolchain default can be
>>>>>> -mthumb: +# Choose between ARM/Thumb instruction sets
>>>>>> +ifeq ($(CONFIG_SYS_THUMB_BUILD),y)
>>>>>> +PF_CPPFLAGS_ARM := $(call cc-option, -mthumb -mthumb-interwork,\
>>>>>> +			$(call cc-option,-marm,)\
>>>>>> +			$(call cc-option,-mno-thumb-interwork,)\
>>>>>> +		)
>>>>>> +else
>>>>>>   PF_CPPFLAGS_ARM := $(call cc-option,-marm,)
>>>>>> +PF_CPPFLAGS_ARM += $(call cc-option,-mno-thumb-interwork,)
>>>>>
>>>>> this 2nd part is no good.  "+=" is not the same thing as ":=".
>>>>
>>>> I don't understand the difference. '+=' is done after ':=' right?
>>>
>>> '+=' is evaluated every file we build, ':=' is evaluated once.  We use
>>> the latter to keep build times down.
>>>
>>
>> Ok. so, are we trying to reduce the number of "+=", right?
>
> Yes, it should already be at or near 0 uses.

We need at least one for finally appending to the exported variable,
right. So, looks like one += for adding '-mthumb -mthumb-interwork'
together is better than having one each for the two options? Is that
the logic?