From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Chou Date: Fri, 24 Feb 2012 09:49:23 +0800 Subject: [U-Boot] [PATCH 1/2] nios2-generic: Fix logic around choosing UART In-Reply-To: <4F41FA1E.3000701@alexhornung.com> References: <1329723235-11978-1-git-send-email-alex@alexhornung.com> <4F41FA1E.3000701@alexhornung.com> Message-ID: <4F46ECA3.9020206@wytron.com.tw> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/20/2012 03:45 PM, Alex Hornung wrote: > On 20/02/12 07:33, Alex Hornung wrote: >> * Before, the normal altera UART driver was compiled in unconditionally >> and the JTAG UART was missed out. >> >> * Work around this by conditionalizing the driver to use based on the >> UART choice in the user's custom FPGA header file. If both were to be >> present, the JTAG UART would have preference. Dear Alex, The preference of jtag uart is not always true. Some people prefer normal uart as it doesn't require the nios2-termial program. As it could be switched easily with a #define CONFIG_ALTERA_JTAG_UART per board config file, this patch is not accepted. Thank you anyway. Best regards, Thomas