From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vipin Kumar Date: Mon, 27 Feb 2012 12:46:39 +0530 Subject: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures In-Reply-To: <4F48B3FB.20200@aribaud.net> References: <1330084720-16878-1-git-send-email-amit.virdi@st.com> <4F48B3FB.20200@aribaud.net> Message-ID: <4F4B2DD7.10009@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/25/2012 3:42 PM, Albert ARIBAUD wrote: > Hi Amit, > Hello Albert, > Le 24/02/2012 12:58, Amit Virdi a ?crit : >> From: Vipin Kumar >> >> Packed attribute is forcing a bytewise write on device registers, >> there by, resulting in a misbehavior on gcc-4.4.1. >> Reverting the structures to non-packed > > If (just asking, not asserting) the issue is caused by fields being u8 > where u8 access is not possible, then should you not make the fields u16 > / u32 according to access requirements? > The problem is not with the fields being of a different width. AFAIK, the packed attribute changes the generated code to access even the word field elements in a byte by byte manner Infact, there is a discussion on lkml that I can point https://lkml.org/lkml/2011/4/27/278 It seems that the discussion did not lead to a conclusion but it was sensible (at least for ARM) to remove the packed attribute from this structure Regards Vipin > Amicalement,