From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Mon, 27 Feb 2012 16:32:22 -0600 Subject: [U-Boot] [PATCH 2/3] SPEAr: Configure FSMC driver for NAND interface In-Reply-To: <201202271102.18797.sr@denx.de> References: <1330335504-32226-1-git-send-email-amit.virdi@st.com> <1330335504-32226-3-git-send-email-amit.virdi@st.com> <201202271102.18797.sr@denx.de> Message-ID: <4F4C0476.3000706@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/27/2012 04:02 AM, Stefan Roese wrote: >> diff --git a/include/configs/spear-common.h >> b/include/configs/spear-common.h index 516b78e..c37305f 100644 >> --- a/include/configs/spear-common.h >> +++ b/include/configs/spear-common.h >> @@ -90,7 +90,7 @@ >> /* NAND FLASH Configuration */ >> #define CONFIG_MTD_DEVICE >> #define CONFIG_MTD_PARTITIONS >> -#define CONFIG_NAND_SPEAR 1 >> +#define CONFIG_NAND_FSMC >> #define CONFIG_SYS_MAX_NAND_DEVICE 1 >> #define CONFIG_MTD_NAND_VERIFY_WRITE > > I suggest that you remove this last define. Most likely it was added for > debugging purpose only. It slows down the speed and it brakes UBI support. What is the problem with UBI? >> +/* NAND flash configuration */ >> +#define CONFIG_SYS_FSMC_NAND_SP >> +#define CONFIG_SYS_FSMC_NAND_8BIT > > You also need the following define for this to work with the latest NAND > subsystem: > > #define CONFIG_MTD_ECC_SOFT > > Not sure about SPEAr3xx. Most likely this needs it as well. This is going to be reverted for now -- I meant to leave it out of the last patchset because of the need to update all boards (which the patch did not do). -Scott