From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: Define change_bit routine
Date: Wed, 29 Feb 2012 00:19:52 +0100 [thread overview]
Message-ID: <4F4D6118.1080405@aribaud.net> (raw)
In-Reply-To: <1330335230-31379-1-git-send-email-amit.virdi@st.com>
Hi Amit,
Le 27/02/2012 10:33, Amit Virdi a ?crit :
> From: Vipin KUMAR<vipin.kumar@st.com>
>
> change_bit routine is left implementation dependent until now.
> This routine is now defined for arm platforms in asm-arm/bitops.h
>
> The Flexible Static memory controller driver, placed in
> mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller
> peripheral from ST. The new driver implements the NAND interface part
> of the peripheral.
>
> Signed-off-by: Vipin Kumar<vipin.kumar@st.com>
> Signed-off-by: Amit Virdi<amit.virdi@st.com>
> ---
> arch/arm/include/asm/bitops.h | 11 +++++++++--
> 1 files changed, 9 insertions(+), 2 deletions(-)
NAK as this is submitted as an isolated patch to dead code.
Provide it as a member of a patchset where some later patch uses it --
and justify that you really need this function.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2012-02-28 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 9:33 [U-Boot] [PATCH] ARM: Define change_bit routine Amit Virdi
2012-02-28 23:19 ` Albert ARIBAUD [this message]
2012-02-29 5:21 ` Amit Virdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4D6118.1080405@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox