From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Wed, 29 Feb 2012 00:19:52 +0100 Subject: [U-Boot] [PATCH] ARM: Define change_bit routine In-Reply-To: <1330335230-31379-1-git-send-email-amit.virdi@st.com> References: <1330335230-31379-1-git-send-email-amit.virdi@st.com> Message-ID: <4F4D6118.1080405@aribaud.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Amit, Le 27/02/2012 10:33, Amit Virdi a ?crit : > From: Vipin KUMAR > > change_bit routine is left implementation dependent until now. > This routine is now defined for arm platforms in asm-arm/bitops.h > > The Flexible Static memory controller driver, placed in > mtd/nand/fsmc_nand.c needs this routine. FSMC is a memory controller > peripheral from ST. The new driver implements the NAND interface part > of the peripheral. > > Signed-off-by: Vipin Kumar > Signed-off-by: Amit Virdi > --- > arch/arm/include/asm/bitops.h | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) NAK as this is submitted as an isolated patch to dead code. Provide it as a member of a patchset where some later patch uses it -- and justify that you really need this function. Amicalement, -- Albert.