From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Wed, 29 Feb 2012 00:44:15 +0100
Subject: [U-Boot] [PATCH 1/5] msm7x30: Add support for low speed uart on
	msm7x30
In-Reply-To: <1329361163-11228-2-git-send-email-mohamed.haneef@lntinfotech.com>
References: <yes>
	<1329361163-11228-2-git-send-email-mohamed.haneef@lntinfotech.com>
Message-ID: <4F4D66CF.7080403@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Mohamed,

Le 16/02/2012 03:59, mohamed.haneef at lntinfotech.com a ?crit :

> +#define UART_CR_TX_DISABLE         (1<<  3)
> +#define UART_CR_TX_ENABLE          (1<<  3)

I doubt the same bit value can mean both enable and disable.

> +#define UART_CR_RX_DISABLE         (1<<  3)
> +#define UART_CR_RX_ENABLE          (1<<  3)

Ditto.

Besides, neither of these defines are used anyway. What's the point of 
having them? I suspect many others are unused, too. Unless there is a 
compelling reason to keep useless defines, remove them.

> The contents of this e-mail and any attachment(s) may contain
> confidential or privileged information for the intended recipient(s).
> Unintended recipients are prohibited from taking action on the basis
> of information in this e-mail and  using or disseminating the
> information,  and must notify the sender and delete it from their
> system. L&T Infotech will not accept responsibility or liability for
> the accuracy or completeness of, or the presence of any virus or
> disabling code in this e-mail"

Please do not post with this footer on the list. It os obnoxious (and 
quite purposeless on a public list :) )

Amicalement,
-- 
Albert.