public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Orjan Friberg <of@flatfrog.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Broken ecc.size when switching between sw and hw ecc (beagleboard)
Date: Wed, 29 Feb 2012 13:12:18 +0100	[thread overview]
Message-ID: <4F4E1622.1080807@flatfrog.com> (raw)

For the beagleboard, ecc.size is not explicitly set when doing 'nandecc 
sw'.  If it's not set for the NAND_ECC_SOFT case in nand_scan_tail, it's 
set to 256 bytes.

When doing 'nandecc hw', ecc.size is set to 512 bytes.  Hence, when 
changing back to 'nandecc sw' ecc.size remains at 512 bytes and suddenly 
the format has changed.


It seems the current nandecc command needs to set this explicitly, but 
also needs to be augmented to be able to select the newly added 4/8-bit 
BCH ECC.

But it also seems like nandecc selection should be more generic than for 
omap3 (currently it lives in arch/arm/cpu/armv7/omap3/board.c).


I have seen that TI did some work on this previously in the 
PSP04.02.00.07 release of u-boot and linux (2.6.37).

Is there ongoing work in this area?  I'd be happy to help out if I can.

(I noticed the nand dump.oob seems to have been fixed in the 
u-boot-nand-flash repo.)


Thanks,
Orjan

-- 
Orjan Friberg
FlatFrog Laboratories AB

             reply	other threads:[~2012-02-29 12:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-29 12:12 Orjan Friberg [this message]
2012-02-29 21:00 ` [U-Boot] Broken ecc.size when switching between sw and hw ecc (beagleboard) Scott Wood
2012-03-01  9:17   ` Orjan Friberg
2012-03-01 17:32     ` Scott Wood
2012-03-02  8:39       ` Orjan Friberg
2012-03-05 18:58   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4E1622.1080807@flatfrog.com \
    --to=of@flatfrog.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox