public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] Highbank fixes for 2012.03
Date: Wed, 29 Feb 2012 08:15:05 -0600	[thread overview]
Message-ID: <4F4E32E9.1060405@gmail.com> (raw)
In-Reply-To: <4F4D59BD.9020606@aribaud.net>

Albert,

On 02/28/2012 04:48 PM, Albert ARIBAUD wrote:
> Hi Rob,
> 
> Le 21/02/2012 23:52, Rob Herring a ?crit :
>> From: Rob Herring<rob.herring@calxeda.com>
>>
>> This is a couple of fixes for a build error and warning.
>>
>> Rob
>>
>> Rob Herring (2):
>>    ARM: highbank: fix warning for calxedaxgmac_initialize
>>    ARM: highbank: add missing get_tbclk
>>
>>   arch/arm/cpu/armv7/highbank/timer.c |    5 +++++
>>   board/highbank/highbank.c           |    1 +
>>   2 files changed, 6 insertions(+), 0 deletions(-)
> 
> Weird: I get a persistent error with ELDK42 (4.2.2) and Ubuntu (4.6.1)
> ARM toolchains:
> 
> calxedaxgmac.c:317: error: expected declaration specifiers or '...'
> before numeric constant
> calxedaxgmac.c:317: warning: function declaration isn't a prototype
> 
> I would not mention it if you did not seem to ba able to build on your
> side, so I must have something wrong in my setup. Can you tell me on
> which commit ID you applied your patch set?

You also need the previous fix that I sent:

http://patchwork.ozlabs.org/patch/139020/

Here's a pull request for all 4 fixes if you prefer:

The following changes since commit 2acca35ce4604dcef933f07d90aa9c9c930e1049:

  Merge branch 'master' of git://git.denx.de/u-boot-mmc (2012-02-17
23:54:46 +0100)

are available in the git repository at:

  git://sources.calxeda.com/u-boot.git fixes

Rob Herring (4):
      net: calxedaxgmac: fix build due to missing __aligned definition
      ARM: highbank: fix warning for calxedaxgmac_initialize
      ARM: highbank: add missing get_tbclk
      ARM: highbank: fix us_to_tick calculation

 arch/arm/cpu/armv7/highbank/timer.c |    9 +++++++--
 board/highbank/highbank.c           |    1 +
 drivers/net/calxedaxgmac.c          |    1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

Thanks,
Rob

      reply	other threads:[~2012-02-29 14:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21 22:52 [U-Boot] [PATCH 0/2] Highbank fixes for 2012.03 Rob Herring
2012-02-21 22:52 ` [U-Boot] [PATCH 1/2] ARM: highbank: fix warning for calxedaxgmac_initialize Rob Herring
2012-02-21 22:52 ` [U-Boot] [PATCH 2/2] ARM: highbank: add missing get_tbclk Rob Herring
2012-02-28 22:48 ` [U-Boot] [PATCH 0/2] Highbank fixes for 2012.03 Albert ARIBAUD
2012-02-29 14:15   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4E32E9.1060405@gmail.com \
    --to=robherring2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox