From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot
Date: Wed, 29 Feb 2012 13:21:16 -0700 [thread overview]
Message-ID: <4F4E88BC.4070106@nvidia.com> (raw)
In-Reply-To: <1330536689-9121-5-git-send-email-sjg@chromium.org>
On 02/29/2012 10:31 AM, Simon Glass wrote:
> Add U-Boot's peripheral clock information to the Tegra20 device tree file.
> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi
> compatible = "nvidia,tegra20-i2c";
> reg = <0x7000C000 0x100>;
> interrupts = < 70 >;
> + clocks = <&tegra_car 12>; /* PERIPH_ID_I2C1 */
> };
The I2C modules all require 2 clocks; the one you've added in this patch
and a second reference to pll_p_out3. Can you please list both of these
here, and update the I2C binding to describe the set of clocks that it
requires. Thanks.
--
nvpublic
next prev parent reply other threads:[~2012-02-29 20:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 17:31 [U-Boot] [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot Simon Glass
2012-02-29 17:31 ` [U-Boot] [PATCH v4 5/9] tegra: i2c: Add I2C driver Simon Glass
2012-02-29 20:30 ` Stephen Warren
2012-03-07 4:46 ` Simon Glass
2012-03-01 7:50 ` Heiko Schocher
2012-03-01 20:29 ` Mike Frysinger
2012-03-07 4:48 ` Simon Glass
2012-02-29 17:31 ` [U-Boot] [PATCH v4 7/9] tegra: i2c: Select I2C ordering for Seaboard Simon Glass
2012-02-29 20:31 ` Stephen Warren
2012-02-29 20:21 ` Stephen Warren [this message]
2012-02-29 20:32 ` [U-Boot] [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot Simon Glass
2012-02-29 20:36 ` Stephen Warren
2012-03-07 4:22 ` Simon Glass
2012-03-07 20:35 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E88BC.4070106@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox