From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 29 Feb 2012 13:36:24 -0700 Subject: [U-Boot] [PATCH v4 4/9] tegra: fdt: i2c: Add extra I2C bindings for U-Boot In-Reply-To: References: <1330536689-9121-5-git-send-email-sjg@chromium.org> <4F4E88BC.4070106@nvidia.com> Message-ID: <4F4E8C48.1020408@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/29/2012 01:32 PM, Simon Glass wrote: > Hi Stephen, > > On Wed, Feb 29, 2012 at 12:21 PM, Stephen Warren wrote: >> On 02/29/2012 10:31 AM, Simon Glass wrote: >>> Add U-Boot's peripheral clock information to the Tegra20 device tree file. >> >>> diff --git a/arch/arm/dts/tegra20.dtsi b/arch/arm/dts/tegra20.dtsi >> >>> compatible = "nvidia,tegra20-i2c"; >>> reg = <0x7000C000 0x100>; >>> interrupts = < 70 >; >>> + clocks = <&tegra_car 12>; /* PERIPH_ID_I2C1 */ >>> }; >> >> The I2C modules all require 2 clocks; the one you've added in this patch >> and a second reference to pll_p_out3. Can you please list both of these >> here, and update the I2C binding to describe the set of clocks that it >> requires. Thanks. > > OK - do you have a pointer to the kernel commit please? I always seem > to have trouble tracking this stuff down. The clock stuff isn't in the kernel yet, so there's no commit to point to. The commit I asked you to create would update the bindings to define which clocks the I2C node needs, and would then go into U-Boot and the kernel. As a reference though, look at the kernel I2C driver and see that it performs two clk_get() calls, and then look into tegra2_clocks.c to see the two clocks it matches. -- nvpublic