From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] ventana: define CONFIG_MACH_VENTANA
Date: Thu, 01 Mar 2012 14:30:12 -0700 [thread overview]
Message-ID: <4F4FEA64.6010902@nvidia.com> (raw)
In-Reply-To: <1330636394-25173-2-git-send-email-troy.kisky@boundarydevices.com>
On 03/01/2012 02:13 PM, Troy Kisky wrote:
> ventana uses board/nvidia/seaboard/seaboard.c
> which uses machine_is_ventana.
> diff --git a/include/configs/ventana.h b/include/configs/ventana.h
> +#define CONFIG_MACH_VENTANA
It'd be nice not to have to do this; that header already does:
#define CONFIG_MACH_TYPE MACH_TYPE_VENTANA
Can't the code key off that? Otherwise, any use of machine_is_xxx() will
be very error-prone, since CONFIG_MACH_XXX has to be manually defined,
and people will forget.
--
nvpublic
next prev parent reply other threads:[~2012-03-01 21:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:13 [U-Boot] [PATCH 1/3] gplugd: use CONFIG_MACH_TYPE instead of MACH_TYPE_SHEEVAD Troy Kisky
2012-03-01 21:13 ` [U-Boot] [PATCH 2/3] ventana: define CONFIG_MACH_VENTANA Troy Kisky
2012-03-01 21:30 ` Stephen Warren [this message]
[not found] ` <4F4FFE7D.7020809@boundarydevices.com>
2012-03-02 1:44 ` Stephen Warren
2012-03-01 21:13 ` [U-Boot] [PATCH 3/3] ARM: Update mach-types Troy Kisky
2012-03-01 21:32 ` Stephen Warren
2012-03-01 21:54 ` Albert ARIBAUD
2012-03-01 22:50 ` Troy Kisky
2012-03-02 7:00 ` Wolfgang Denk
2012-03-02 17:45 ` Stephen Warren
2012-03-02 19:37 ` Troy Kisky
2012-03-02 20:08 ` Stephen Warren
2012-03-02 21:07 ` Troy Kisky
2012-03-03 10:15 ` [U-Boot] [PATCH 1/3] gplugd: use CONFIG_MACH_TYPE instead of MACH_TYPE_SHEEVAD Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4FEA64.6010902@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox