From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Thu, 01 Mar 2012 14:30:12 -0700 Subject: [U-Boot] [PATCH 2/3] ventana: define CONFIG_MACH_VENTANA In-Reply-To: <1330636394-25173-2-git-send-email-troy.kisky@boundarydevices.com> References: <1330636394-25173-1-git-send-email-troy.kisky@boundarydevices.com> <1330636394-25173-2-git-send-email-troy.kisky@boundarydevices.com> Message-ID: <4F4FEA64.6010902@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/01/2012 02:13 PM, Troy Kisky wrote: > ventana uses board/nvidia/seaboard/seaboard.c > which uses machine_is_ventana. > diff --git a/include/configs/ventana.h b/include/configs/ventana.h > +#define CONFIG_MACH_VENTANA It'd be nice not to have to do this; that header already does: #define CONFIG_MACH_TYPE MACH_TYPE_VENTANA Can't the code key off that? Otherwise, any use of machine_is_xxx() will be very error-prone, since CONFIG_MACH_XXX has to be manually defined, and people will forget. -- nvpublic