[U-Boot] [PATCH 3/3] ARM: Update mach-types

Stephen Warren
2012-03-02T17:45:36Z

On 03/02/2012 12:00 AM, Wolfgang Denk wrote:
> Dear Troy Kisky,
>
> In message <4F4FFD1F.4080406@boundarydevices.com> you wrote:
>>
>>> Not sure I understand why we have a "machine_ix_xxx()" here. Could you >
>>> explain?
>>>
>>> Amicalement,
>>
>> Because board/nvidia/seaboard/seaboard.c uses machine_is_ventana but >
>> that machine is no longer
>> in mach-types.
>
> Then fix the seaboard.c code, please, instead of adding dead code.

I think that should actually be very easy. Can't the following:

if (machine_is_foo()) {
...
}

be converted to:

#if CONFIG_MACH_TYPE == MACH_TYPE_FOO
...
#endif

As a related note, I expect you'll see more and more boards that don't
exist in the kernel's mach-type.h since people won't register machine
IDs for boards that only support device tree.

--
nvpublic