From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Thu, 01 Mar 2012 22:54:53 +0100
Subject: [U-Boot] [PATCH 3/3] ARM: Update mach-types
In-Reply-To: <1330636394-25173-3-git-send-email-troy.kisky@boundarydevices.com>
References: <1330636394-25173-1-git-send-email-troy.kisky@boundarydevices.com>
	<1330636394-25173-3-git-send-email-troy.kisky@boundarydevices.com>
Message-ID: <4F4FF02D.1020804@aribaud.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Troy,

Le 01/03/2012 22:13, Troy Kisky a ?crit :

> diff --git a/include/configs/ea20.h b/include/configs/ea20.h
> index b4610d9..da49ae8 100644
> --- a/include/configs/ea20.h
> +++ b/include/configs/ea20.h
> @@ -24,6 +24,18 @@
>   #define __CONFIG_H
>
>   /*
> + * FIXME: This belongs in mach-types.h.  However, we only pull mach-types
> + * from Linus' kernel.org tree.
> + */
> +#include<asm/mach-types.h>
> +#ifdef MACH_TYPE_EA20
> +#error "MACH_TYPE_EA20 has been defined properly, please remove this."
> +#else
> +#define MACH_TYPE_EA20		3002
> +#endif
> +
> +
> +/*

Sorry if I am being pedantic here, but the "FIXME" comment actually 
belongs *below* the #include line, not above. Ditto for others.

> diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
> index 261f952..8589b1d 100644
> --- a/include/configs/seaboard.h
> +++ b/include/configs/seaboard.h
> @@ -45,6 +45,13 @@
>
>   #define CONFIG_BOARD_EARLY_INIT_F
>
> +/*
> + * FIXME: This belongs in mach-types.h.  However, we only pull mach-types
> + * from Linus' kernel.org tree.
> + */
> +#define machine_is_ventana()	(0)

Not sure I understand why we have a "machine_ix_xxx()" here. Could you 
explain?

Amicalement,
-- 
Albert.