[U-Boot] [PATCH] Enable high speed support for USB device framework and usbtty

Marek Vasut
2012-03-02T10:41:34Z

> Hi Marek,
>
> >>>> +#if defined(CONFIG_USBD_HS)
> >>>> +/**
> >>>> + * usbd_device_qualifier_descriptor
> >>>> + * @device: which device
> >>>> + * @port: which port
> >>>> + *
> >>>> + * Return the specified qualifier descriptor for the specified
> >>>> device. + */
> >>>> +struct usb_qualifier_descriptor *usbd_device_qualifier_descriptor(
> >>>> + struct usb_device_instance *device, int port)
> >>>
> >>> Make this static, but do you really need this function at all?
> >>
> >> Well... usbd_device_qualifier_descriptor can't be static as the function
> >> is called from another file (ep0.c). However, since it is used only for
> >> EP0, it can be omitted for the time being keeping in mind we might need
> >> to define it in future (if the need arises). What do you think?
> >
> > What do you mean. If this is called from ep0.c, it has to be exported and
> > that's how it is. On the other hand, if ep0.c already has access to the
> > "device", it can directly access the device_descriptor field, which is I
> > believe expressive enough.
>
> Yes, ep0.c has direct access to the "device" field. I'll omit the
> usbd_device_qualifier_descriptor function in V2.
>

Thank you :-)

M