From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Virdi <amit.virdi@st.com>
Date: Fri, 2 Mar 2012 16:57:40 +0530
Subject: [U-Boot] [PATCH 1/7] net/designware: Fix to restore hw mac
	address
In-Reply-To: <201202291409.33186.vapier@gentoo.org>
References: <1330511846-1243-1-git-send-email-amit.virdi@st.com>
	<1330511846-1243-2-git-send-email-amit.virdi@st.com>
	<201202291409.33186.vapier@gentoo.org>
Message-ID: <4F50AEAC.5020600@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de



On 3/1/2012 12:39 AM, Mike Frysinger wrote:
> On Wednesday 29 February 2012 05:37:20 Amit Virdi wrote:
>> The network controller mac resets hardware address stored in MAC_HI and
>> MAC_LO registers if mac is resetted. So, hw mac address needs to be
>> restored in case mac is explicitly resetted from driver.
>
> OK, but ...
>
>> --- a/drivers/net/designware.c
>> +++ b/drivers/net/designware.c
>>
>> +	dw_write_hwaddr(dev);
>
> ... please add a comment above this line explaining why you must explicitly
> make this call

Ok, Mike. I'll send V2 with comment added.

Thanks
Amit Virdi