[U-Boot] [PATCH 5/7] net/designware: Try configuring phy on each dw_eth_init

Amit Virdi
2012-03-06T04:21:48Z

Dear Wonfgang,

On 3/6/2012 12:35 AM, Wolfgang Denk wrote:
> Dear Amit Virdi,
>
> In message<4F54AF08.1030003@st.com> you wrote:
>>
>> Surprisingly, I could still not find "true" and "false" defined for ARM
>> architecture or in a common file that I can include. Here's what grep
>> gives me
>
> So don't use these.
>
> In theory, any use of #define TRUE / FALSE or enum bool or plain use
> of raw 0 and 1 is fine - but only as long as you make sure to use this
> consistently within the whole project.
>
> If I am forced to use something like this, I prefer the enum as this
> can be decoded by a debugger. But in general, I try to avod it, and
> use plain C logic instead - because then I can just read and
> understand the code, in all other cases I have to look up definitions,
> especially when it comes to parameter passings.
>
> In your specific case, you use TRUE and FALSE just in one single
> place, for one single variable. Dumpt that. Use 0 and 1, and
> everybody can read the code.
>

Thanks for explaining so well. I shall be sending V2 incorporating your
suggestion.

Best Regards
Amit Virdi