[U-Boot] [PATCH 5/7] net/designware: Try configuring phy on each dw_eth_init

Amit Virdi
2012-03-05T12:18:16Z

Dear Mike,

On 3/3/2012 12:08 AM, Mike Frysinger wrote:
> On Friday 02 March 2012 06:40:07 Amit Virdi wrote:
>> On 3/1/2012 12:41 AM, Mike Frysinger wrote:
>>>> + u32 phy_configured;
>>>>
>>>>> +#define FALSE (0)
>>>>> +#define TRUE (!FALSE)
>>>
>>> NAK: we already have "true" and "false" and the "bool" type. use those
>>> instead.
>>
>> Are you sure Mike? I couldn't find in u-boot code "TRUE" and "FALSE"
>> defined in any common header file.
>
> i said "true" and "false", not "TRUE" and "FALSE"

Surprisingly, I could still not find "true" and "false" defined for ARM
architecture or in a common file that I can include. Here's what grep
gives me

----
bash-3.2$ git grep -i "define true" -- *.[h]
arch/arm/cpu/ixp/npe/include/IxOsalTypes.h:#define TRUE 1L
board/Marvell/db64360/mv_eth.h:#define TRUE 1
board/Marvell/db64460/mv_eth.h:#define TRUE 1
board/amcc/bamboo/bamboo.h:#define TRUE 1
board/bf533-ezkit/flash-defines.h:#define TRUE 0x1
board/bf533-stamp/video.h:#define true 1
board/esd/common/lcd.h:#define TRUE (!FALSE)
board/esd/cpci750/mv_eth.h:#define TRUE 1
board/prodrive/p3mx/mv_eth.h:#define TRUE 1
board/sacsng/clkinit.h:#define TRUE (!FALSE)
board/xilinx/common/xbasic_types.h:#define TRUE 1
drivers/block/sata_dwc.h:#define TRUE 1
drivers/net/armada100_fec.h:#define TRUE 1
drivers/net/ne2000_base.h:#define true 1
include/at91rm9200_net.h:#define TRUE 1
include/bedbug/ppc.h:#define TRUE (!FALSE)
include/fpga.h:#define TRUE (!FALSE)
include/scsi.h:#define TRUE 1
include/sym53c8xx.h:#define TRUE 1
include/xyzModem.h:#define true 1
lib/bzlib_private.h:#define True ((Bool)1)
lib/lzma/Types.h:#define True 1
----

You might be pointing to
arch/blackfin/include/asm/posix_types.h:typedef enum { false = 0, true =
1 } bool;
but this is for blackfin architecture.

Can you please suggest me which bool types are you referring here?

Thanks
Amit Virdi