From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Fri, 02 Mar 2012 14:07:17 -0700 Subject: [U-Boot] [PATCH 3/3] ARM: Update mach-types In-Reply-To: <4F4FFD1F.4080406@boundarydevices.com> References: <1330636394-25173-1-git-send-email-troy.kisky@boundarydevices.com> <1330636394-25173-3-git-send-email-troy.kisky@boundarydevices.com> <4F4FF02D.1020804@aribaud.net> <4F4FFD1F.4080406@boundarydevices.com> Message-ID: <4F513685.4080605@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 3/1/2012 3:50 PM, Troy Kisky wrote: > On 3/1/2012 2:54 PM, Albert ARIBAUD wrote: >> Hi Troy, >> >> Le 01/03/2012 22:13, Troy Kisky a ?crit : >> >>> diff --git a/include/configs/ea20.h b/include/configs/ea20.h >>> index b4610d9..da49ae8 100644 >>> --- a/include/configs/ea20.h >>> +++ b/include/configs/ea20.h >>> @@ -24,6 +24,18 @@ >>> #define __CONFIG_H >>> >>> /* >>> + * FIXME: This belongs in mach-types.h. However, we only pull >>> mach-types >>> + * from Linus' kernel.org tree. >>> + */ >>> +#include >>> +#ifdef MACH_TYPE_EA20 >>> +#error "MACH_TYPE_EA20 has been defined properly, please remove this." >>> +#else >>> +#define MACH_TYPE_EA20 3002 >>> +#endif >>> + >>> + >>> +/* >> >> Sorry if I am being pedantic here, but the "FIXME" comment actually >> belongs *below* the #include line, not above. Ditto for others. > > I put it above because when it is moved to mach-types.h, the include > should be deleted as well. That is part of the "FIXME." Did I convince you, or do you still want it changed? Thanks Troy