From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Sat, 03 Mar 2012 10:59:26 +0100 Subject: [U-Boot] [PATCH v2] mx31: Setup AIPS registers In-Reply-To: References: <1330544699-21814-1-git-send-email-festevam@gmail.com> <4F4E847B.9000406@googlemail.com> <4F4F177A.7050005@de.bosch.com> Message-ID: <4F51EB7E.3010306@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/03/2012 13:29, Fabio Estevam wrote: > On Thu, Mar 1, 2012 at 3:30 AM, Dirk Behme wrote: > >> Ah, thanks for the explanation! :) >> >> This does mean that you want the change in both, U-Boot and kernel, correct? > > Correct. > >> Yes, we definitely should look at which parts are common. I haven't looked >> at the details, but at least the register definitions [1] are the same? > > Yes, I can write a common code for this. > > 1. The aips register definitions: > > /* AIPS registers */ > struct aipstz_regs { > u32 mprot0; > u32 mprot1; > u32 rsvd[0xe]; > u32 opacr0; > u32 opacr1; > u32 opacr2; > u32 opacr3; > u32 opacr4; > }; > > should be present in each imx-regs.h file (for mx31/35/51/53/6), right? > > Or is there a common .h file I could use for placing it in just one location? There is not, but I am also coming to the conclusion that we need some sort of common files, exactly as the kernel does with plat-imx. Maybe in arch/arm/include/asm/plat-imx ? Then all imx-regs.h must include the common file. I am sure we will add them more things, because there are several parts that are still duplicated in code. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================