[U-Boot] [PATCH 1/3] i.MX6: mx6qsabrelite: add CONFIG_REVISION_TAG

Wolfgang Denk
2012-03-04T22:06:51Z

Dear Eric Nelson,

In message <4F53D8E6.4000408@boundarydevices.com> you wrote:
>
> Since U-Boot doesn't really have a configuration step, I find that
> folks tend to tweak the board configuration file quite a bit based
> on their needs.

Yes, peaople do that a lot, nd it has always been a very good idea to
at least detect such modifications of the code. The worst thing to
happen is when you receive a bug report for version FOO, and you have
no chance of detecting that somebody actually messed with the
configuration and/or the code.

> Though it's a bit of a hack, we even formalized it on our i.MX5x products
> to allow customers to keep their git repositories clean:
> ....
[Link deleted to not further distribute this horrible stuff.]

Frankly, this "keep their git repositories clean" is a really, really
bad idea. We pay special care to add the git commit ID to the U-Boot
version string so you can easily detect if somebody messed with the
code, and you come up and invent methods of circumventing that.

This is totally counterproductive.

If you use this, that's your business. But please do me the favour and
do not recommend this to others.

Thanks.

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alliance: In international politics, the union of two thieves who
have their hands so deeply inserted in each other's pocket that they
cannot separately plunder a third. - Ambrose Bierce