public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] i.MX6: mx6qsabrelite: add CONFIG_REVISION_TAG
Date: Sun, 04 Mar 2012 13:35:14 -0700	[thread overview]
Message-ID: <4F53D202.7060808@boundarydevices.com> (raw)
In-Reply-To: <201203022359.50525.marex@denx.de>

On 03/02/2012 03:59 PM, Marek Vasut wrote:
>>   Freescale 2.6.38 (Non-DT) kernels require the revision atag to
>>   enable the VPU.
>>
>> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
>> ---
>>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |    7 +++++++
>>   include/configs/mx6qsabrelite.h               |    1 +
>>   2 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> b/board/freescale/mx6qsabrelite/mx6qsabrelite.c index db1bea9..590030b
>> 100644
>> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> @@ -215,6 +215,13 @@ int board_mmc_init(bd_t *bis)
>>   }
>>   #endif
>>
>> +#ifdef CONFIG_REVISION_TAG
>> +u32 get_board_rev(void)
>> +{
>> +	return 0x63000 ;
>> +}
>> +#endif
>> +
>>   #ifdef CONFIG_MXC_SPI
>>   iomux_v3_cfg_t ecspi1_pads[] = {
>>   	/* SS1 */
>> diff --git a/include/configs/mx6qsabrelite.h
>> b/include/configs/mx6qsabrelite.h index 93000f0..85f6f7a 100644
>> --- a/include/configs/mx6qsabrelite.h
>> +++ b/include/configs/mx6qsabrelite.h
>> @@ -33,6 +33,7 @@
>>   #define CONFIG_CMDLINE_TAG
>>   #define CONFIG_SETUP_MEMORY_TAGS
>>   #define CONFIG_INITRD_TAG
>> +#define CONFIG_REVISION_TAG
>
> I think you can avoid this define altogether, you're using it anyway.
>
Hi Marek,

I'm not sure I understand.

I need to define CONFIG_REVISION_TAG in order to get bootm to add
the tag:
	http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/lib/bootm.c;h=afa0093df7620606ee12b4dc1dd2ee37adee347c;hb=master#l137

I made get_board_rev() conditional so we can get rid of it if (once)
we're only using DT kernels.

  reply	other threads:[~2012-03-04 20:35 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 22:55 [U-Boot] i.MX6: mx6qsabrelite: allow use with Freescale 2.6.38 kernels Eric Nelson
2012-03-02 22:55 ` [U-Boot] [PATCH 1/3] i.MX6: mx6qsabrelite: add CONFIG_REVISION_TAG Eric Nelson
2012-03-02 22:59   ` Marek Vasut
2012-03-04 20:35     ` Eric Nelson [this message]
2012-03-04 20:59       ` Marek Vasut
2012-03-04 21:04         ` Eric Nelson
2012-03-04 21:18           ` Marek Vasut
2012-03-04 22:06           ` Wolfgang Denk
2012-03-04 22:41             ` Eric Nelson
2012-03-03 10:26   ` Stefano Babic
2012-03-02 22:55 ` [U-Boot] [PATCH 2/3] i.MX6: mx6qsabrelite: add MACH_TYPE_MX6Q_SABRELITE Eric Nelson
2012-03-02 23:00   ` Marek Vasut
2012-03-03 10:28   ` Stefano Babic
2012-03-02 22:55 ` [U-Boot] [PATCH 3/3] i.MX6: mx6qsabrelite: add ext2 support Eric Nelson
2012-03-07  9:36   ` Stefano Babic
2012-03-02 23:01 ` [U-Boot] i.MX6: mx6qsabrelite: allow use with Freescale 2.6.38 kernels Marek Vasut
2012-03-02 23:25 ` Wolfgang Denk
2012-03-02 23:46   ` Eric Nelson
2012-03-02 23:50     ` Fabio Estevam
2012-03-03  9:33     ` Wolfgang Denk
2012-03-03  6:35   ` Dirk Behme
2012-03-03  9:38     ` Wolfgang Denk
2012-03-03 10:43       ` mailander
2012-03-03 11:32       ` Dirk Behme
2012-03-03 13:30         ` Wolfgang Denk
2012-03-04  1:19           ` Troy Kisky
2012-03-04  8:39             ` Wolfgang Denk
2012-03-07  9:37               ` Albert ARIBAUD
2012-03-04 11:09           ` Stefano Babic
2012-03-04 14:14             ` Igor Grinberg
2012-03-04 19:45             ` [U-Boot] CONFIG_REVISION (was i.MX6: mx6qsabrelite: allow use with Freescale 2.6.38 kernels) Eric Nelson
2012-03-07  8:43               ` Stefano Babic
2012-03-07 15:53                 ` Eric Nelson
2012-03-07 16:32                   ` Stefano Babic
2012-03-03 10:33   ` [U-Boot] i.MX6: mx6qsabrelite: allow use with Freescale 2.6.38 kernels Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F53D202.7060808@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox