From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Mon, 05 Mar 2012 06:43:54 -0700 Subject: [U-Boot] [PATCH 2/4] net: fec_mxc: allow use with cache enabled In-Reply-To: <201203050249.33765.marex@denx.de> References: <1330729572-12642-1-git-send-email-eric.nelson@boundarydevices.com> <201203030039.55661.marex@denx.de> <4F53F737.4040509@boundarydevices.com> <201203050249.33765.marex@denx.de> Message-ID: <4F54C31A.1050701@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03/04/2012 06:49 PM, Marek Vasut wrote: >> On 03/02/2012 04:39 PM, Marek Vasut wrote: >>>> + * Invalidate data cache over the buffer >>>> + */ >>>> + addr = (uint32_t)frame; >>>> + size = roundup(frame_length, CONFIG_FEC_DATA_ALIGNMENT); >>>> + invalidate_dcache_range(addr, addr + size); >>> >>> DTTO here, frame length might not be aligned properly, or will it be? >>> Network stack must be properly analyzed here. >> >> The hardware won't return an unaligned value here, so this should be good. > > Are you sure? You can't receive frame aligned to 8 bytes boundary? Unless I'm missing something, received packet start addresses are defined by the driver in fec_rbd_init(), the code just modified to use memalign, so we're good here.