public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled
Date: Tue, 06 Mar 2012 11:08:43 -0700	[thread overview]
Message-ID: <4F5652AB.6060307@boundarydevices.com> (raw)
In-Reply-To: <4F564427.9050002@boundarydevices.com>

On 03/06/2012 10:06 AM, Eric Nelson wrote:
> On 03/05/2012 01:06 PM, Marek Vasut wrote:
>> Dear Eric Nelson,
>>
 >> <snip>
 >>
>>> + if (!fec->rbd_base) {
>>> + ret = -ENOMEM;
>>> + goto err2;
>>> + }
>>> + memset(fec->rbd_base, 0, size);
>>> + }
>>
>> We might want to flush the descriptors to memory after they have been inited?
>

We're also missing a flush after the call to fec_rbd_init().

I'm inclined to move that call to right after the memset and before
a newly-added flush and do the same with the call to tbd_init().

  reply	other threads:[~2012-03-06 18:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <http://lists.denx.de/pipermail/u-boot/2012-March/#119217>
2012-03-05 18:36 ` [U-Boot] [PATCH V2 0/1] net: fec_mxc: allow use with cache enabled Eric Nelson
2012-03-05 18:36   ` [U-Boot] [PATCH V2] " Eric Nelson
2012-03-05 20:06     ` Marek Vasut
2012-03-05 20:19       ` Wolfgang Denk
2012-03-05 20:23         ` Marek Vasut
2012-03-06 17:06       ` Eric Nelson
2012-03-06 18:08         ` Eric Nelson [this message]
2012-03-06 19:49           ` Marek Vasut
2012-03-06 21:21             ` Eric Nelson
2012-03-06 21:38               ` Marek Vasut
2012-03-06 19:45         ` Marek Vasut
2012-03-06 21:19           ` Eric Nelson
2012-03-06 21:22             ` Marek Vasut
2012-03-06 21:28               ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5652AB.6060307@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox