From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Tue, 06 Mar 2012 11:08:43 -0700
Subject: [U-Boot] [PATCH V2] net: fec_mxc: allow use with cache enabled
In-Reply-To: <4F564427.9050002@boundarydevices.com>
References: <http://lists.denx.de/pipermail/u-boot/2012-March/#119217>
	<1330972603-23782-1-git-send-email-eric.nelson@boundarydevices.com>
	<1330972603-23782-2-git-send-email-eric.nelson@boundarydevices.com>
	<201203052106.42334.marex@denx.de>
	<4F564427.9050002@boundarydevices.com>
Message-ID: <4F5652AB.6060307@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 03/06/2012 10:06 AM, Eric Nelson wrote:
> On 03/05/2012 01:06 PM, Marek Vasut wrote:
>> Dear Eric Nelson,
>>
 >> <snip>
 >>
>>> + if (!fec->rbd_base) {
>>> + ret = -ENOMEM;
>>> + goto err2;
>>> + }
>>> + memset(fec->rbd_base, 0, size);
>>> + }
>>
>> We might want to flush the descriptors to memory after they have been inited?
>

We're also missing a flush after the call to fec_rbd_init().

I'm inclined to move that call to right after the memset and before
a newly-added flush and do the same with the call to tbd_init().