From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prabhakar Kushwaha <prabhakar@freescale.com>
Date: Wed, 7 Mar 2012 09:36:08 +0530
Subject: [U-Boot] [PATCH 3/4] powerpc/85xx:Update NOR code base to
 support debugger
In-Reply-To: <20120306144531.ECE32202D7D@gemini.denx.de>
References: <1329296055-28541-1-git-send-email-prabhakar@freescale.com>
	<20120306144531.ECE32202D7D@gemini.denx.de>
Message-ID: <4F56DEB0.6060500@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Tuesday 06 March 2012 08:15 PM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message<1329296055-28541-1-git-send-email-prabhakar@freescale.com>  you wrote:
>> Update the NOR code base to support NOR-boot debugging.
>> It ovecome e500 and e500v2's second limitation i.e. IVPR + IVOR15 should be
>> valid fetchable OP code address.
>>
>> While executing in translated space (AS=1), whenever a debug exception is
>> generated, the MSR[DS/IS] gets cleared and the processor tries to fetch an
>> instruction from the debug exception vector (IVPR|IVOR15); since now we are in
>> AS=0, the application needs to ensure the proper configuration to have
>> IVOR|IVOR15 accessible from AS=0 also.
>>
>> Signed-off-by: Radu Lazarescu<radu.lazarescu@freescale.com>
>> Signed-off-by: Prabhakar Kushwaha<prabhakar@freescale.com>
> ...
>> +	_mas0 = MAS0_TLBSEL(1) |
>> +			MAS0_ESEL(CONFIG_DEBUGGER_TEMP_TLB);
> You are using an undocumented CONFIG_ option here.

This CONFIG_ is defined as part of documentation patch sent in this series


>> +++ b/arch/powerpc/cpu/mpc85xx/start.S
>> @@ -184,6 +184,48 @@ l2_disabled:
>>   	andi.	r1,r3,L1CSR0_DCE at l
>>   	beq	2b
>>
>> +#if defined(CONFIG_E500_V1_V2)&&  !defined(CONFIG_SYS_RAMBOOT)
> What if no such debug support is needed, and code size hurts?
>

sure it will. I agree with you.
But this piece of code overcome debug restriction of e500 and e500v2 
cores and  I think fixing restriction is a good way to go.


>> @@ -107,6 +107,7 @@
>>   #define CONFIG_MAX_CPUS			1
>>   #define CONFIG_FSL_SDHC_V2_3
>>   #define CONFIG_SYS_FSL_NUM_LAWS		12
>> +#define CONFIG_DEBUGGER_TEMP_TLB	3
> Undocumented!
>
This CONFIG_ is defined as part of documentation patch sent in this series

--Prabhakar