From: Amit Virdi <amit.virdi@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures
Date: Wed, 7 Mar 2012 14:00:24 +0530 [thread overview]
Message-ID: <4F571CA0.1060104@st.com> (raw)
In-Reply-To: <201203061351.40228.marex@denx.de>
Dear Marek,
>> I did the changes suggested by you and tested the build. The issue
>> didn't come up. Then I reverted the code to the original (attributes
>> retained and ehci directly de-referencing the pointers. The issue didn't
>> come here too.
>>
>> Today, I used armv7-linux-gcc (GCC) v4.6.2
>> So I suspect there has been some fix done in the GCC.
>>
>> Now, even with the packed attributes, the word fields are accessed
>> word-by-word in contrast to the earlier observed behavior
>> (byte-by-byte). I could see ldr and str in the disassembly.
>>
>> May be, we can discard this patch and keep drivers/usb/host/ehci.h intact.
>
> Can you check with different toolchain please?
>
Do you mean different toolchains for ARM? I can surely check if you can
help me. I have used ST's internal distribution till date and I guess I
need to download and install other ARM toolchains in order to verify
this issue.
Or, we can work this way that my source code is compiled by someone
already installed/using other tool chains. I can test it on my board and
report the results?
Thanks
Amit Virdi
next prev parent reply other threads:[~2012-03-07 8:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 11:58 [U-Boot] [PATCH] USB:host: Attribute packed removed from usb structures Amit Virdi
2012-02-24 19:18 ` Mike Frysinger
2012-02-27 10:02 ` Amit Virdi
2012-02-27 18:25 ` Mike Frysinger
2012-02-25 10:12 ` Albert ARIBAUD
2012-02-27 7:16 ` Vipin Kumar
2012-02-27 13:14 ` Marek Vasut
2012-02-27 18:26 ` Mike Frysinger
2012-02-27 20:53 ` Marek Vasut
2012-02-28 0:56 ` Mike Frysinger
2012-02-29 10:25 ` Amit Virdi
2012-03-06 12:06 ` Amit Virdi
2012-03-06 12:51 ` Marek Vasut
2012-03-07 8:30 ` Amit Virdi [this message]
2012-03-07 11:38 ` Marek Vasut
2012-03-07 12:12 ` Amit Virdi
2012-03-06 16:11 ` Mike Frysinger
2012-03-07 8:23 ` Amit Virdi
2012-03-07 13:33 ` Mike Frysinger
2012-03-07 13:49 ` Amit Virdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F571CA0.1060104@st.com \
--to=amit.virdi@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox