From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] imximage: Remove overwriting of flash_offset
Date: Wed, 07 Mar 2012 10:33:58 +0100 [thread overview]
Message-ID: <4F572B86.9010109@denx.de> (raw)
In-Reply-To: <1329987019-24379-1-git-send-email-dirk.behme@de.bosch.com>
On 23/02/2012 09:50, Dirk Behme wrote:
> The flash header supports different flash offsets for different
> boot devices. E.g. parallel NOR or OneNAND use a different offset
> than FLASH_OFFSET_STANDARD (== 0x400).
>
> The flash offset is correctly read from the configuration in
> parse_cfg_cmd(). But is then overwritten wrongly in set_imx_hdr_v1/2().
>
> Fix this by removing this overwriting. Use the flash offset
> correctly read from the configuration, instead.
>
> If there is no flash_offset read from the configuration file, i.e.
> the BOOT_FROM tag is missing, exit with an error message.
>
> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com>
> CC: Jason Liu <liu.h.jason@gmail.com>
> CC: Stefano Babic <sbabic@denx.de>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2012-03-07 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 8:50 [U-Boot] [PATCH v2] imximage: Remove overwriting of flash_offset Dirk Behme
2012-02-23 13:10 ` Stefano Babic
2012-02-23 14:44 ` Dirk Behme
2012-03-07 8:23 ` Stefano Babic
2012-03-07 9:33 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F572B86.9010109@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox