[U-Boot] [PATCH 1/3] i.MX6: mx6qsabrelite: add CONFIG_REVISION_TAG

Eric Nelson
2012-03-04T22:41:51Z

On 03/04/2012 03:06 PM, Wolfgang Denk wrote:
> Dear Eric Nelson,
>
> In message<4F53D8E6.4000408@boundarydevices.com> you wrote:
>>
>> Since U-Boot doesn't really have a configuration step, I find that
>> folks tend to tweak the board configuration file quite a bit based
>> on their needs.
>
> Yes, peaople do that a lot, nd it has always been a very good idea to
> at least detect such modifications of the code. The worst thing to
> happen is when you receive a bug report for version FOO, and you have
> no chance of detecting that somebody actually messed with the
> configuration and/or the code.
>
>> Though it's a bit of a hack, we even formalized it on our i.MX5x products
>> to allow customers to keep their git repositories clean:
>> ....
> [Link deleted to not further distribute this horrible stuff.]
>
> Frankly, this "keep their git repositories clean" is a really, really
> bad idea. We pay special care to add the git commit ID to the U-Boot
> version string so you can easily detect if somebody messed with the
> code, and you come up and invent methods of circumventing that.
>
> This is totally counterproductive.
>
> If you use this, that's your business. But please do me the favour and
> do not recommend this to others.
>

We don't. Sorry if I implied otherwise.

We recommend that customers keep their own repositories with changes
from our "standard" releases, but we have a number of customers whose
complete set of differences amounts to default environment variables
and/or choices of serial consoles for which we don't want to carry and
publish an entire configuration.

This hack was borne out of frustration when getting a 'revision-dirty'
reference back from a customer because they've changed something
simple (usually environment settings).