public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] ns16550: tegra: Specify debugging serial port at boot.
Date: Thu, 08 Mar 2012 11:08:56 -0700	[thread overview]
Message-ID: <4F58F5B8.6070402@wwwdotorg.org> (raw)
In-Reply-To: <1325890269-5613-1-git-send-email-swarren@nvidia.com>

On 01/06/2012 05:51 AM, Stephen Warren wrote:
> From: Doug Anderson <dianders@chromium.org>
> 
> This works together with a kernel change that looks at the scratchpad
> register to determine which of the many UARTs it should use for early
> printing:
> 
> http://www.spinics.net/lists/arm-kernel/msg154633.html
> 
> While it is unfortunate to need to pass this information in a second way
> (it's already in the device tree), this does allow the very early boot
> code (decompressing stub and early assembly code) to print to the right
> port.
> 
> At the moment, I'm adding this to the UART init function. Alternatively,
> we could add a more complex patch to key off of the 'console' setting.
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> [swarren: Limited the change to Tegra platforms]
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Doug Anderson <dianders@chromium.org>

I noticed this patch isn't applied yet that I can find. Are there any
comments on it; can it be applied? Thanks.

For reference, it's in patchwork at:
http://patchwork.ozlabs.org/patch/134712/

> ---
> drivers/serial/ns16550.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
> index 0c23955..19a28cd 100644
> --- a/drivers/serial/ns16550.c
> +++ b/drivers/serial/ns16550.c
> @@ -62,6 +62,13 @@ void NS16550_init(NS16550_t com_port, int baud_divisor)
>  	serial_out(0, &com_port->mdr1);
>  #endif
>  #endif /* CONFIG_OMAP */
> +#if defined(CONFIG_TEGRA2)
> +	/*
> +	 * Put a 'D' in the scratchpad to let the kernel know which UART
> +	 * for earlyprintk [D]ebugging.
> +	 */
> +	serial_out('D', &com_port->spr);
> +#endif
>  }
>  
>  #ifndef CONFIG_NS16550_MIN_FUNCTIONS

  parent reply	other threads:[~2012-03-08 18:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 22:51 [U-Boot] [PATCH] ns16550: tegra: Specify debugging serial port at boot Stephen Warren
2012-01-10  1:26 ` Doug Anderson
2012-03-08 18:08 ` Stephen Warren [this message]
2012-03-08 18:39   ` [U-Boot] " Wolfgang Denk
2012-03-08 19:40     ` Stephen Warren
2012-03-08 21:29       ` Wolfgang Denk
2012-03-08 21:43         ` Stephen Warren
2012-03-08 23:26           ` Graeme Russ
2012-03-13 20:12     ` Stephen Warren
2012-03-13 21:23       ` Graeme Russ

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F58F5B8.6070402@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox