From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/4] ns16550: Add function to drain serial output
Date: Fri, 09 Mar 2012 14:40:17 -0700 [thread overview]
Message-ID: <4F5A78C1.1030405@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ34SjYWv1A-yZ9Y5BaXPZs3hY8W6OCuLtux5hpqkVykvQ@mail.gmail.com>
On 03/09/2012 02:29 PM, Simon Glass wrote:
> On Fri, Mar 9, 2012 at 1:23 PM, Tom Warren <TWarren@nvidia.com> wrote:
>> sjg at google.com wrote at Friday, March 09, 2012 2:09 PM:
...
>>> 2. I have held off responding to Stephen's patch on the ML to see what other
>>> say. My view is that it is controversial since it changes the so-far
>>> accepted meaning of u-boot.bin and the behaviour of the U-Boot Makefile.
>>> Plus it is not really necessary as a means of informing the user since we
>>> put the pre-console putc() for exactly this problem. So I would rather leave
>>> Stephen's patch out at until people have time to decide that I am wrong
>>> about it. We already have CONFIG_OF_EMBED to build the fdt into u-boot.bin.
>>> Grant Likely had big reservations about this feature - let's not bring it in
>>> by stealth.
I don't quite see how this is bringing the feature in by stealth; the
exact same set of files (one with and without appended DTB already in
place) is still available, just under filenames that are likely to cause
less surprise to the user.
...
> Stephen, what you do you about leaving out your Makefile patch for
> now? It is (I think) the only controversial part of this, and is not
> needed to make all this work...
Yes, I'm happy with that. The issue I had was the surprising result of
U-Boot hanging without giving any clues why, and that's addressed by the
messages that are now printed with your latest patches.
While I still like the patch to rename the files in the top-level
Makefile, I do agree that including it in a pull request without more
widespread discussion and agreement is not a good idea.
BTW, happy birthday Tom.
next prev parent reply other threads:[~2012-03-09 21:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 20:32 [U-Boot] [PATCH v2 1/4] ns16550: Add function to drain serial output Simon Glass
2012-03-09 20:32 ` [U-Boot] [PATCH v2 2/4] Enable printf() console if pre-console putc() is available Simon Glass
2012-03-09 20:32 ` [U-Boot] [PATCH v2 3/4] tegra: Implement pre-console putc() for fdt warning Simon Glass
2012-03-10 8:16 ` Wolfgang Denk
2012-03-10 19:22 ` Simon Glass
2012-03-10 20:08 ` Wolfgang Denk
2012-03-10 21:25 ` Simon Glass
2012-03-10 22:49 ` Wolfgang Denk
2012-03-11 0:48 ` Simon Glass
2012-03-09 20:32 ` [U-Boot] [PATCH v2 4/4] tegra: Enable pre-console putc() for Tegra boards Simon Glass
2012-03-09 20:59 ` [U-Boot] [PATCH v2 1/4] ns16550: Add function to drain serial output Tom Warren
2012-03-10 8:20 ` Wolfgang Denk
2012-03-09 21:00 ` Stephen Warren
2012-03-09 21:08 ` Simon Glass
2012-03-09 21:23 ` Tom Warren
2012-03-09 21:29 ` Simon Glass
2012-03-09 21:40 ` Stephen Warren [this message]
2012-03-10 8:19 ` Wolfgang Denk
2012-03-10 19:27 ` Simon Glass
2012-03-10 20:24 ` Wolfgang Denk
2012-03-11 0:52 ` Simon Glass
2012-03-11 2:06 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A78C1.1030405@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox