public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ATMEL: use generic mmc framework
Date: Sat, 10 Mar 2012 12:26:31 +0100	[thread overview]
Message-ID: <4F5B3A67.9030609@gmail.com> (raw)
In-Reply-To: <1319201366-9132-2-git-send-email-svens@stackframe.org>

Dear Sven,

On 21.10.2011 14:49, Sven Schnelle wrote:
> gen_atmel_mci works on AVR32 as well, so no need to use the legacy
> mmc driver. This also has the nice side effect of being able to use
> SDHC cards an those boards.
> 
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> ---
>  arch/avr32/lib/board.c            |    6 +
>  board/atmel/atngw100/atngw100.c   |   10 ++
>  board/atmel/atstk1000/atstk1000.c |   10 ++
>  drivers/mmc/atmel_mci.h           |  245 ------------------------------------
>  include/atmel_mci.h               |  247 +++++++++++++++++++++++++++++++++++++
>  include/configs/atngw100.h        |    4 +-
>  include/configs/atstk1002.h       |    4 +-
>  include/configs/atstk1003.h       |    3 +-
>  include/configs/atstk1004.h       |    4 +-
>  include/configs/atstk1006.h       |    4 +-
>  include/configs/favr-32-ezkit.h   |    3 +-
>  include/configs/hammerhead.h      |    3 +-
>  include/configs/mimc200.h         |    3 +-
>  include/mmc.h                     |    1 -
>  14 files changed, 293 insertions(+), 254 deletions(-)
>  delete mode 100644 drivers/mmc/atmel_mci.h
>  create mode 100644 include/atmel_mci.h

I did test this driver and decided to apply it now to u-boot-avr32 but
unfortunately there is one final issue. You switched all avr32 boards to
the generic driver by changing the board includes but missed the
necessary 'int board_mmc_init(bd_t *bd)' in some boards (namely mimc200,
hammerhead and favr-32-ezkit).

I guess you can not react suddenly on this mail and I'd like to apply it
now. Therefore I will modify this patch and provide a weak 'int
board_mmc_init(bd_t *bd)' in board.c.

regards

Andreas Bie?mann

  reply	other threads:[~2012-03-10 11:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21 12:49 [U-Boot] [PATCH v2] ATMEL: switch atmel_mci users to gen_atmel_mci Sven Schnelle
2011-10-21 12:49 ` [U-Boot] [PATCH 1/2] ATMEL: use generic mmc framework Sven Schnelle
2012-03-10 11:26   ` Andreas Bießmann [this message]
2012-03-10 12:45     ` [U-Boot] [PATCH v3] " Andreas Bießmann
2012-03-13 13:33       ` Andreas Bießmann
2011-10-21 12:49 ` [U-Boot] [PATCH 2/2] ATMEL: remove old atmel_mci driver Sven Schnelle
2012-03-13 13:35   ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5B3A67.9030609@gmail.com \
    --to=andreas.devel@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox