From mboxrd@z Thu Jan  1 00:00:00 1970
From: Prabhakar Kushwaha <prabhakar@freescale.com>
Date: Mon, 12 Mar 2012 14:17:09 +0530
Subject: [U-Boot] [PATCH 2/2][v2] powerpc/85xx:Add PSC9131 RDB Support
In-Reply-To: <20120307121103.CA1AE202C7F@gemini.denx.de>
References: <1329304781-27758-1-git-send-email-prabhakar@freescale.com>
	<20120306151120.3EAB4202D7D@gemini.denx.de>
	<4F56FC6D.8080401@freescale.com>
	<20120307121103.CA1AE202C7F@gemini.denx.de>
Message-ID: <4F5DB80D.5000900@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Wednesday 07 March 2012 05:41 PM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message<4F56FC6D.8080401@freescale.com>  you wrote:
>>>> +#define CONFIG_ADDR_STREAMING		/* toggle addr streaming */
>>> What is this good for?
>>>
>>> It is undocumented, and there is no code that uses it.
>> This #define is no more in used. I just copy pasted from P1010RDB.h and
>> P1_P2_RDB.h.
>> i will remove it.
> It would be nice if you could provide an additional cleanup patch that
> removes the stale #define from the other files as well.

Sure. I will try..

>>>> +#define CONFIG_HOSTNAME		PSC9131rdb
>>>> +#define CONFIG_ROOTPATH		"/opt/nfsroot"
>>>> +#define CONFIG_BOOTFILE		"uImage"
>>>> +#define CONFIG_UBOOTPATH	u-boot.bin /* U-Boot image on TFTP server */
>>>> +
>>>> +#define CONFIG_BAUDRATE		115200
>>>> +
>>>> +#define	CONFIG_EXTRA_ENV_SETTINGS				\
>>>> +	"netdev=eth0\0"						\
>>>> +	"uboot=" MK_STR(CONFIG_UBOOTPATH) "\0"				\
>>> Why didn't you follow my change request here?  Define as "u-boot.bin"
>>> so it is at least consistent with the other strings, and drop the
>>> MK_STR here.
>>>
>>> ...
>> The requirement is to use u-boot.bin instead of CONFIG_UBOOTPATH?
>> is my understanding correct?
> No.  Use
>
> 	#define CONFIG_UBOOTPATH	"u-boot.bin"	/* U-Boot image on TFTP server */
>
> so that you can then use
>
> 	#define   CONFIG_EXTRA_ENV_SETTINGS \
> 		"netdev=eth0\0" \
> 		"uboot=" CONFIG_UBOOTPATH "\0" \
> 		...
>
> without the use of MK_STR(), and all string defines are done in a
> consistent way.

Got it :)


I will provide the updated version asap.

Thanks,
Prabhakar