From mboxrd@z Thu Jan  1 00:00:00 1970
From: Amit Virdi <amit.virdi@st.com>
Date: Mon, 12 Mar 2012 19:27:50 +0530
Subject: [U-Boot] [PATCH 23/25] SPEAr: Use separate config flags for 3xx
 and 6xx board files
In-Reply-To: <201203071538.59432.sr@denx.de>
References: <1331121854-20494-1-git-send-email-amit.virdi@st.com>
	<1331121854-20494-24-git-send-email-amit.virdi@st.com>
	<201203071538.59432.sr@denx.de>
Message-ID: <4F5E00DE.6090100@st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

>> diff --git a/board/spear/common/Makefile b/board/spear/common/Makefile
>> index 11f81e4..48dcfd3 100644
>> --- a/board/spear/common/Makefile
>> +++ b/board/spear/common/Makefile
>> @@ -29,9 +29,14 @@ endif
>>
>>   LIB	= $(obj)lib$(VENDOR).o
>>
>> -COBJS	:= spr_misc.o
>> -SOBJS	:= spr_lowlevel_init.o
>> +COBJS-$(CONFIG_SPEAR3XX) += spr_misc.o
>> +COBJS-$(CONFIG_SPEAR600) += spr_misc.o
>>
>> +SOBJS-$(CONFIG_SPEAR3XX) += spr_lowlevel_init.o
>> +SOBJS-$(CONFIG_SPEAR600) += spr_lowlevel_init.o
>> +
>> +COBJS	:= $(sort $(COBJS-y))
>> +SOBJS	:= $(sort $(SOBJS-y))
>>   SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
>>   OBJS	:= $(addprefix $(obj),$(COBJS))
>>   SOBJS	:= $(addprefix $(obj),$(SOBJS))
>
> I don't really see the benefit of this patch. Could you please explain a bit
> more why this is needed/better?
>

Although it is better this way but the original intention to introduce 
this patch was to add more features which I didn't added in this 
patchset since this patchset aims to provide bug fixes in the already 
existing SPEAr support in u-boot.

Maybe, I can drop this patch in V2.

Regards
Amit Virdi