From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] fs/fat: align disk buffers on cache line to enable DMA and cache
Date: Mon, 12 Mar 2012 18:24:35 -0700 [thread overview]
Message-ID: <4F5EA1D3.8040207@boundarydevices.com> (raw)
In-Reply-To: <1330897580-8931-1-git-send-email-eric.nelson@boundarydevices.com>
On 03/04/2012 02:46 PM, Eric Nelson wrote:
> Signed-off-by: Eric Nelson<eric.nelson@boundarydevices.com>
> Acked-by: Mike Frysinger<vapier@gentoo.org>
> ---
> fs/fat/fat.c | 14 ++++++++------
> 1 files changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/fs/fat/fat.c b/fs/fat/fat.c
> index 1f95eb4..f3c48bb 100644
> --- a/fs/fat/fat.c
> +++ b/fs/fat/fat.c
> @@ -31,6 +31,8 @@
> #include<fat.h>
> #include<asm/byteorder.h>
> #include<part.h>
> +#include<malloc.h>
> +#include<linux/compiler.h>
>
> /*
> * Convert a string to lowercase.
> @@ -62,7 +64,7 @@ static int disk_read(__u32 block, __u32 nr_blocks, void *buf)
>
> int fat_register_device (block_dev_desc_t * dev_desc, int part_no)
> {
> - unsigned char buffer[dev_desc->blksz];
> + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buffer, dev_desc->blksz);
> <snip>
Hi Wolfgang,
Have you had a chance to review this patch? Is there another maintainer for fs/fat?
Please let me know if you need this updated.
There's another patch that was acked by Mike but is otherwise lingering here:
http://lists.denx.de/pipermail/u-boot/2012-March/119309.html
Both of these are needed before enabling the data cache on i.MX6 when using
the FAT filesystem.
Regards,
Eric
next prev parent reply other threads:[~2012-03-13 1:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <119311>
2012-03-04 21:46 ` [U-Boot] [PATCH V2] fs/fat: align disk buffers on cache line to enable DMA and cache Eric Nelson
2012-03-13 1:24 ` Eric Nelson [this message]
2012-03-24 7:18 ` Dirk Behme
2012-03-27 14:20 ` Anatolij Gustschin
2012-03-27 16:28 ` Dirk Behme
2012-03-27 16:40 ` Anatolij Gustschin
2012-03-27 18:21 ` Tom Rini
2012-04-19 6:35 ` Dirk Behme
2012-04-24 9:14 ` Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5EA1D3.8040207@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox