public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
Date: Tue, 13 Mar 2012 09:28:10 +0100	[thread overview]
Message-ID: <4F5F051A.6040609@denx.de> (raw)
In-Reply-To: <1331600652-30247-1-git-send-email-eric.nelson@boundarydevices.com>

On 13/03/2012 02:04, Eric Nelson wrote:
> This is needed to support Freescale-supplied userspaces.
> 
> At the moment, both the IPU and VPU libraries provided by Freescale
> in the "imx-lib" package contain routines which scrape the system
> revision from /proc/cpuinfo. In the VPU library, this information is
> used to load the proper firmware, allowing a single binary to be used
> across various i.MX processors.
> 

Hi Eric,


> V3 removes the conditional surrounding get_board_rev() as requested by 
> Marek.

This lines are your changelog and should be not in the commit message.
They must be after the "---" line.


> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  board/freescale/mx6qsabrelite/mx6qsabrelite.c |    5 +++++
>  include/configs/mx6qsabrelite.h               |    1 +
>  2 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 7fe2dc9..1d09a72 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -215,6 +215,11 @@ int board_mmc_init(bd_t *bis)
>  }
>  #endif
>  
> +u32 get_board_rev(void)
> +{
> +	return 0x63000 ;
> +}
> +
>  #ifdef CONFIG_MXC_SPI
>  iomux_v3_cfg_t ecspi1_pads[] = {
>  	/* SS1 */
> diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
> index bb3a46b..a1a2267 100644
> --- a/include/configs/mx6qsabrelite.h
> +++ b/include/configs/mx6qsabrelite.h
> @@ -33,6 +33,7 @@
>  #define CONFIG_CMDLINE_TAG
>  #define CONFIG_SETUP_MEMORY_TAGS
>  #define CONFIG_INITRD_TAG
> +#define CONFIG_REVISION_TAG
>  
>  /* Size of malloc() pool */
>  #define CONFIG_SYS_MALLOC_LEN          (CONFIG_ENV_SIZE + 2 * 1024 * 1024)

Apart of that:

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  parent reply	other threads:[~2012-03-13  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <http://lists.denx.de/pipermail/u-boot/2012-March/#119207>
2012-03-13  1:04 ` [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG Eric Nelson
2012-03-13  2:30   ` Marek Vasut
2012-03-13  8:28   ` Stefano Babic [this message]
2012-03-13 12:57     ` Eric Nelson
2012-03-13 13:37       ` Stefano Babic
2012-03-15  8:49   ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5F051A.6040609@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox