* [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
2012-03-13 1:04 ` [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG Eric Nelson
@ 2012-03-13 2:30 ` Marek Vasut
2012-03-13 8:28 ` Stefano Babic
2012-03-15 8:49 ` Stefano Babic
2 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2012-03-13 2:30 UTC (permalink / raw)
To: u-boot
Dear Eric Nelson,
> This is needed to support Freescale-supplied userspaces.
>
> At the moment, both the IPU and VPU libraries provided by Freescale
> in the "imx-lib" package contain routines which scrape the system
> revision from /proc/cpuinfo. In the VPU library, this information is
> used to load the proper firmware, allowing a single binary to be used
> across various i.MX processors.
>
> V3 removes the conditional surrounding get_board_rev() as requested by
> Marek.
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
2012-03-13 1:04 ` [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG Eric Nelson
2012-03-13 2:30 ` Marek Vasut
@ 2012-03-13 8:28 ` Stefano Babic
2012-03-13 12:57 ` Eric Nelson
2012-03-15 8:49 ` Stefano Babic
2 siblings, 1 reply; 6+ messages in thread
From: Stefano Babic @ 2012-03-13 8:28 UTC (permalink / raw)
To: u-boot
On 13/03/2012 02:04, Eric Nelson wrote:
> This is needed to support Freescale-supplied userspaces.
>
> At the moment, both the IPU and VPU libraries provided by Freescale
> in the "imx-lib" package contain routines which scrape the system
> revision from /proc/cpuinfo. In the VPU library, this information is
> used to load the proper firmware, allowing a single binary to be used
> across various i.MX processors.
>
Hi Eric,
> V3 removes the conditional surrounding get_board_rev() as requested by
> Marek.
This lines are your changelog and should be not in the commit message.
They must be after the "---" line.
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 5 +++++
> include/configs/mx6qsabrelite.h | 1 +
> 2 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 7fe2dc9..1d09a72 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -215,6 +215,11 @@ int board_mmc_init(bd_t *bis)
> }
> #endif
>
> +u32 get_board_rev(void)
> +{
> + return 0x63000 ;
> +}
> +
> #ifdef CONFIG_MXC_SPI
> iomux_v3_cfg_t ecspi1_pads[] = {
> /* SS1 */
> diff --git a/include/configs/mx6qsabrelite.h b/include/configs/mx6qsabrelite.h
> index bb3a46b..a1a2267 100644
> --- a/include/configs/mx6qsabrelite.h
> +++ b/include/configs/mx6qsabrelite.h
> @@ -33,6 +33,7 @@
> #define CONFIG_CMDLINE_TAG
> #define CONFIG_SETUP_MEMORY_TAGS
> #define CONFIG_INITRD_TAG
> +#define CONFIG_REVISION_TAG
>
> /* Size of malloc() pool */
> #define CONFIG_SYS_MALLOC_LEN (CONFIG_ENV_SIZE + 2 * 1024 * 1024)
Apart of that:
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
2012-03-13 8:28 ` Stefano Babic
@ 2012-03-13 12:57 ` Eric Nelson
2012-03-13 13:37 ` Stefano Babic
0 siblings, 1 reply; 6+ messages in thread
From: Eric Nelson @ 2012-03-13 12:57 UTC (permalink / raw)
To: u-boot
On 03/13/2012 01:28 AM, Stefano Babic wrote:
> On 13/03/2012 02:04, Eric Nelson wrote:
>> This is needed to support Freescale-supplied userspaces.
>>
>> At the moment, both the IPU and VPU libraries provided by Freescale
>> in the "imx-lib" package contain routines which scrape the system
>> revision from /proc/cpuinfo. In the VPU library, this information is
>> used to load the proper firmware, allowing a single binary to be used
>> across various i.MX processors.
>>
>
> Hi Eric,
>
>
>> V3 removes the conditional surrounding get_board_rev() as requested by
>> Marek.
>
> This lines are your changelog and should be not in the commit message.
> They must be after the "---" line.
>
Thanks Stefano,
Do you want me to re-send?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
2012-03-13 12:57 ` Eric Nelson
@ 2012-03-13 13:37 ` Stefano Babic
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2012-03-13 13:37 UTC (permalink / raw)
To: u-boot
On 13/03/2012 13:57, Eric Nelson wrote:
> Thanks Stefano,
>
> Do you want me to re-send?
No, sorry, you do not need it - I fix it myself.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG
2012-03-13 1:04 ` [U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add CONFIG_REVISION_TAG Eric Nelson
2012-03-13 2:30 ` Marek Vasut
2012-03-13 8:28 ` Stefano Babic
@ 2012-03-15 8:49 ` Stefano Babic
2 siblings, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2012-03-15 8:49 UTC (permalink / raw)
To: u-boot
On 13/03/2012 02:04, Eric Nelson wrote:
> This is needed to support Freescale-supplied userspaces.
>
> At the moment, both the IPU and VPU libraries provided by Freescale
> in the "imx-lib" package contain routines which scrape the system
> revision from /proc/cpuinfo. In the VPU library, this information is
> used to load the proper firmware, allowing a single binary to be used
> across various i.MX processors.
>
> V3 removes the conditional surrounding get_board_rev() as requested by
> Marek.
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread