* [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc
@ 2012-03-14 13:14 Chander Kashyap
2012-03-14 13:32 ` Kyungmin Park
0 siblings, 1 reply; 6+ messages in thread
From: Chander Kashyap @ 2012-03-14 13:14 UTC (permalink / raw)
To: u-boot
TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
usase of tzpc.
Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
---
arch/arm/include/asm/arch-exynos/tzpc.h | 2 +-
board/samsung/smdk5250/tzpc_init.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
index 2c9a07b..63736ae 100644
--- a/arch/arm/include/asm/arch-exynos/tzpc.h
+++ b/arch/arm/include/asm/arch-exynos/tzpc.h
@@ -22,7 +22,7 @@
#define __TZPC_H_
#ifndef __ASSEMBLY__
-struct exynos5_tzpc {
+struct s5p_tzpc {
unsigned int r0size;
char res1[0x7FC];
unsigned int decprot0stat;
diff --git a/board/samsung/smdk5250/tzpc_init.c b/board/samsung/smdk5250/tzpc_init.c
index c2ccef3..03e46bb 100644
--- a/board/samsung/smdk5250/tzpc_init.c
+++ b/board/samsung/smdk5250/tzpc_init.c
@@ -28,7 +28,7 @@
/* Setting TZPC[TrustZone Protection Controller] */
void tzpc_init(void)
{
- struct exynos5_tzpc *tzpc;
+ struct s5p_tzpc *tzpc;
unsigned int addr;
for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) {
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc
2012-03-14 13:14 [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc Chander Kashyap
@ 2012-03-14 13:32 ` Kyungmin Park
2012-03-14 13:38 ` Chander Kashyap
0 siblings, 1 reply; 6+ messages in thread
From: Kyungmin Park @ 2012-03-14 13:32 UTC (permalink / raw)
To: u-boot
Hi Chander,
On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
<chander.kashyap@linaro.org> wrote:
> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
> usase of tzpc.
>
> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>
> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
> ---
> ?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +-
> ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +-
> ?2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
> index 2c9a07b..63736ae 100644
> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
> @@ -22,7 +22,7 @@
> ?#define __TZPC_H_
>
> ?#ifndef __ASSEMBLY__
> -struct exynos5_tzpc {
> +struct s5p_tzpc {
I think 'exynos' is preferable. Even though each SOC has different
number of tzpc. It can be covered one exynos_tzpc. or we can define
it for each SoC.
Thank you,
Kyungmin Park
> ? ? ? ?unsigned int r0size;
> ? ? ? ?char res1[0x7FC];
> ? ? ? ?unsigned int decprot0stat;
> diff --git a/board/samsung/smdk5250/tzpc_init.c b/board/samsung/smdk5250/tzpc_init.c
> index c2ccef3..03e46bb 100644
> --- a/board/samsung/smdk5250/tzpc_init.c
> +++ b/board/samsung/smdk5250/tzpc_init.c
> @@ -28,7 +28,7 @@
> ?/* Setting TZPC[TrustZone Protection Controller] */
> ?void tzpc_init(void)
> ?{
> - ? ? ? struct exynos5_tzpc *tzpc;
> + ? ? ? struct s5p_tzpc *tzpc;
> ? ? ? ?unsigned int addr;
>
> ? ? ? ?for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) {
> --
> 1.7.5.4
>
>
> _______________________________________________
> linaro-dev mailing list
> linaro-dev at lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/linaro-dev
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc
2012-03-14 13:32 ` Kyungmin Park
@ 2012-03-14 13:38 ` Chander Kashyap
2012-03-15 1:23 ` Minkyu Kang
0 siblings, 1 reply; 6+ messages in thread
From: Chander Kashyap @ 2012-03-14 13:38 UTC (permalink / raw)
To: u-boot
Hi Kyungmin Park,
On 14 March 2012 19:02, Kyungmin Park <kmpark@infradead.org> wrote:
> Hi Chander,
>
> On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
> <chander.kashyap@linaro.org> wrote:
>> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
>> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
>> usase of tzpc.
>>
>> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>>
>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>> ---
>> ?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +-
>> ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +-
>> ?2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
>> index 2c9a07b..63736ae 100644
>> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
>> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
>> @@ -22,7 +22,7 @@
>> ?#define __TZPC_H_
>>
>> ?#ifndef __ASSEMBLY__
>> -struct exynos5_tzpc {
>> +struct s5p_tzpc {
> I think 'exynos' is preferable. Even though each SOC has different
I tried to carry forward old conventions as in case of watchdog. I
will change it to exynos.
> number of tzpc. It can be covered one exynos_tzpc. or ?we can define
> it for each SoC.
One structure is enough as fields are same.
>
> Thank you,
> Kyungmin Park
>> ? ? ? ?unsigned int r0size;
>> ? ? ? ?char res1[0x7FC];
>> ? ? ? ?unsigned int decprot0stat;
>> diff --git a/board/samsung/smdk5250/tzpc_init.c b/board/samsung/smdk5250/tzpc_init.c
>> index c2ccef3..03e46bb 100644
>> --- a/board/samsung/smdk5250/tzpc_init.c
>> +++ b/board/samsung/smdk5250/tzpc_init.c
>> @@ -28,7 +28,7 @@
>> ?/* Setting TZPC[TrustZone Protection Controller] */
>> ?void tzpc_init(void)
>> ?{
>> - ? ? ? struct exynos5_tzpc *tzpc;
>> + ? ? ? struct s5p_tzpc *tzpc;
>> ? ? ? ?unsigned int addr;
>>
>> ? ? ? ?for (addr = TZPC0_BASE; addr <= TZPC9_BASE; addr += TZPC_BASE_OFFSET) {
>> --
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> linaro-dev mailing list
>> linaro-dev at lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/linaro-dev
--
with warm regards,
Chander Kashyap
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc
2012-03-14 13:38 ` Chander Kashyap
@ 2012-03-15 1:23 ` Minkyu Kang
2012-03-15 3:30 ` Chander Kashyap
2012-03-15 3:55 ` [U-Boot] [Samsung] " Tushar Behera
0 siblings, 2 replies; 6+ messages in thread
From: Minkyu Kang @ 2012-03-15 1:23 UTC (permalink / raw)
To: u-boot
Dear Chander Kashyap,
On 14 March 2012 22:38, Chander Kashyap <chander.kashyap@linaro.org> wrote:
> Hi Kyungmin Park,
>
> On 14 March 2012 19:02, Kyungmin Park <kmpark@infradead.org> wrote:
>> Hi Chander,
>>
>> On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
>> <chander.kashyap@linaro.org> wrote:
>>> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
>>> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
>>> usase of tzpc.
>>>
>>> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>>>
>>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>>> ---
>>> ?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +-
>>> ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +-
>>> ?2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
>>> index 2c9a07b..63736ae 100644
>>> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
>>> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
>>> @@ -22,7 +22,7 @@
>>> ?#define __TZPC_H_
>>>
>>> ?#ifndef __ASSEMBLY__
>>> -struct exynos5_tzpc {
>>> +struct s5p_tzpc {
>> I think 'exynos' is preferable. Even though each SOC has different
> I tried to carry forward old conventions as in case of watchdog. I
> will change it to exynos.
I agreed with Kyungmin.
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc
2012-03-15 1:23 ` Minkyu Kang
@ 2012-03-15 3:30 ` Chander Kashyap
2012-03-15 3:55 ` [U-Boot] [Samsung] " Tushar Behera
1 sibling, 0 replies; 6+ messages in thread
From: Chander Kashyap @ 2012-03-15 3:30 UTC (permalink / raw)
To: u-boot
Dear Minkyu,
On 15 March 2012 06:53, Minkyu Kang <promsoft@gmail.com> wrote:
> Dear Chander Kashyap,
>
> On 14 March 2012 22:38, Chander Kashyap <chander.kashyap@linaro.org> wrote:
>> Hi Kyungmin Park,
>>
>> On 14 March 2012 19:02, Kyungmin Park <kmpark@infradead.org> wrote:
>>> Hi Chander,
>>>
>>> On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
>>> <chander.kashyap@linaro.org> wrote:
>>>> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
>>>> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
>>>> usase of tzpc.
>>>>
>>>> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>>>>
>>>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>>>> ---
>>>> ?arch/arm/include/asm/arch-exynos/tzpc.h | ? ?2 +-
>>>> ?board/samsung/smdk5250/tzpc_init.c ? ? ?| ? ?2 +-
>>>> ?2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> index 2c9a07b..63736ae 100644
>>>> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> @@ -22,7 +22,7 @@
>>>> ?#define __TZPC_H_
>>>>
>>>> ?#ifndef __ASSEMBLY__
>>>> -struct exynos5_tzpc {
>>>> +struct s5p_tzpc {
>>> I think 'exynos' is preferable. Even though each SOC has different
>> I tried to carry forward old conventions as in case of watchdog. I
>> will change it to exynos.
>
> I agreed with Kyungmin.
> From now, let's called "exynos" for common name including s5pc1xx and
> s5pc2xx and exynos4 and exynos5.. etc.
Thanks for the inputs. Let us follow the convention. I will resubmit the patch.
>
>>
>>> number of tzpc. It can be covered one exynos_tzpc. or ?we can define
>>> it for each SoC.
>> One structure is enough as fields are same.
>>
>
> Thanks
> Minkyu Kang.
> --
> from. prom.
> www.promsoft.net
--
with warm regards,
Chander Kashyap
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [Samsung] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc
2012-03-15 1:23 ` Minkyu Kang
2012-03-15 3:30 ` Chander Kashyap
@ 2012-03-15 3:55 ` Tushar Behera
1 sibling, 0 replies; 6+ messages in thread
From: Tushar Behera @ 2012-03-15 3:55 UTC (permalink / raw)
To: u-boot
On 03/15/2012 06:53 AM, Minkyu Kang wrote:
> Dear Chander Kashyap,
>
> On 14 March 2012 22:38, Chander Kashyap <chander.kashyap@linaro.org> wrote:
>> Hi Kyungmin Park,
>>
>> On 14 March 2012 19:02, Kyungmin Park <kmpark@infradead.org> wrote:
>>> Hi Chander,
>>>
>>> On Wed, Mar 14, 2012 at 10:14 PM, Chander Kashyap
>>> <chander.kashyap@linaro.org> wrote:
>>>> TZPC IP is common across S5P and Exynos based SoC'c. Renaming exynos5_tzpc
>>>> in arch/arm/include/asm/arch-exynos/tzpc.h to s5p_tzpc will allow generic
>>>> usase of tzpc.
>>>>
>>>> Also modify board/samsung/smdk5250/tzpc_init.c to use s5p_tzpc.
>>>>
>>>> Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org>
>>>> ---
>>>> arch/arm/include/asm/arch-exynos/tzpc.h | 2 +-
>>>> board/samsung/smdk5250/tzpc_init.c | 2 +-
>>>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/arch/arm/include/asm/arch-exynos/tzpc.h b/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> index 2c9a07b..63736ae 100644
>>>> --- a/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> +++ b/arch/arm/include/asm/arch-exynos/tzpc.h
>>>> @@ -22,7 +22,7 @@
>>>> #define __TZPC_H_
>>>>
>>>> #ifndef __ASSEMBLY__
>>>> -struct exynos5_tzpc {
>>>> +struct s5p_tzpc {
>>> I think 'exynos' is preferable. Even though each SOC has different
>> I tried to carry forward old conventions as in case of watchdog. I
>> will change it to exynos.
>
> I agreed with Kyungmin.
> From now, let's called "exynos" for common name including s5pc1xx and
> s5pc2xx and exynos4 and exynos5.. etc.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-15 3:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-14 13:14 [U-Boot] [PATCH] EXYNOS: Rename exynos5_tzpc structure to s5p_tzpc Chander Kashyap
2012-03-14 13:32 ` Kyungmin Park
2012-03-14 13:38 ` Chander Kashyap
2012-03-15 1:23 ` Minkyu Kang
2012-03-15 3:30 ` Chander Kashyap
2012-03-15 3:55 ` [U-Boot] [Samsung] " Tushar Behera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox